Uh oh!
There was an error while loading. Please reload this page.
gh-97956: Mention generate_global_objects.py in AC How-To - #97957
Conversation
sobolevn
commented
Oct 6, 2022
Looks like GitHub Actions are broken right now. I will re-run the CI a bit later. |
sobolevn
commented
Oct 6, 2022
Re-triggering |
larryhastings
left a comment
There was a problem hiding this comment.
It's a good idea to add this step to the documentation. But I have some suggestions on how to rewrite the text to make it a little clearer. Please take a look!
| 16. Compile, then run the relevant portions of the regression-test suite. | ||
| 16. Code generated by Argument Clinic might use ``_Py_ID`` macro inside. |
There was a problem hiding this comment.
- Argument Clinic may generate new instances of
_Py_ID. For example::
| &_Py_ID(new_unique_py_id) | ||
| It means that you would need to run ``Tools/scripts/generate_global_objects.py`` |
There was a problem hiding this comment.
If it does, you'll have to run Tools/scripts/generate_global_objects.py to regenerate the list of precompiled identifiers at this point.
There was a problem hiding this comment.
Thanks, done!
It is always great to have native-speakers to double check things like this. I think in another language and it does not translate that well into English in some cases :)
sobolevn
commented
Oct 6, 2022
Looks like the CI failure is somehow related to f612565 |
JulienPalard
commented
Oct 7, 2022
@sobolevn I think that the CI issues has been fixed (sphinx-lint side for some false postives, and cpython side for the few true positives), can you please rebase your branch on top of main? |
sobolevn
commented
Oct 7, 2022
It works now 🎉 |
JulienPalard
commented
Oct 7, 2022
Yeah! It's better like that :) Sorry for the inconvenience :( |
* main: (38 commits) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) pythonGH-83901: Improve Signature.bind error message for missing keyword-only params (python#95347) pythongh-61105: Add default param, note on using cookiejar subclass (python#95427) pythongh-96288: Add a sentence to `os.mkdir`'s docstring. (python#96271) pythongh-96073: fix backticks in NEWS entry (pythonGH-98056) pythongh-92886: [clinic.py] raise exception on invalid input instead of assertion (pythonGH-98051) pythongh-97997: Add col_offset field to tokenizer and use that for AST nodes (python#98000) pythonGH-88968: Reject socket that is already used as a transport (python#98010) pythongh-96346: Use double caching for re._compile() (python#96347) pythongh-91708: Revert params note in urllib.parse.urlparse table (python#96699) pythongh-96265: Fix some formatting in faq/design.rst (python#96924) pythongh-73196: Add namespace/scope clarification for inheritance section (python#92840) pythongh-97646: Change `.js` and `.mjs` files mimetype to conform to RFC 9239 (python#97934) pythongh-97923: Always run Ubuntu SSL tests with others in CI (python#97940) pythongh-97956: Mention `generate_global_objects.py` in `AC How-To` (python#97957) pythongh-96959: Update HTTP links which are redirected to HTTPS (python#98039) ...
generate_global_objectsstep #97956