Skip to content

GH-94597: Deprecate child watcher getters and setters - #98215

Merged
gvanrossum merged 8 commits into
python:mainfrom
kumaraditya303:watcher
Oct 15, 2022
Merged

GH-94597: Deprecate child watcher getters and setters#98215
gvanrossum merged 8 commits into
python:mainfrom
kumaraditya303:watcher

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Oct 12, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@kumaraditya303kumaraditya303 added topic-asyncio 🔨 test-with-buildbots Test PR w/ buildbots; report in status section labels Oct 12, 2022
@bedevere-bot

bedevere-bot commented Oct 12, 2022

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 9020f36 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-botbedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Oct 12, 2022
@kumaraditya303

kumaraditya303 commented Oct 12, 2022

Copy link
Copy Markdown
ContributorAuthor

The buildbots failures are unrelated. See #98216

@kumaraditya303
kumaraditya303 marked this pull request as ready for review October 12, 2022 15:45
@kumaraditya303kumaraditya303 mentioned this pull request Oct 12, 2022
Closed
gvanrossum
gvanrossum reviewed Oct 15, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super keen on indenting all that code, otherwise I am fine with this. However, could you also add some deprecation notes to the docs? What's new in 3.12 also ideally should be updated (isn't there already something about watchers there?)

Comment threadLib/asyncio/unix_events.py
Comment threadLib/asyncio/unix_events.py Outdated
@kumaraditya303

kumaraditya303 commented Oct 15, 2022

Copy link
Copy Markdown
ContributorAuthor

However, could you also add some deprecation notes to the docs? What's new in 3.12 also ideally should be updated (isn't there already something about watchers there?)

I was planning to finish docs afterwards but I added it now.

gvanrossum
gvanrossum approved these changes Oct 15, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge.

Comment threadLib/asyncio/unix_events.py
@gvanrossum
gvanrossum merged commit 660f102 into python:mainOct 15, 2022
@kumaraditya303
kumaraditya303 deleted the watcher branch October 16, 2022 03:19
graingert
graingert reviewed Oct 16, 2022
View reviewed changes
Comment threadLib/asyncio/unix_events.py
await transp._wait()
raise
with warnings.catch_warnings():
warnings.simplefilter('ignore', DeprecationWarning)

@graingertgraingertOct 16, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It isn't safe to disable warnings here, this is a process global and you're disabiling it for the whole wait

@graingertgraingert mentioned this pull request Oct 16, 2022
Closed
carljm added a commit to carljm/cpython that referenced this pull request Oct 17, 2022
@carljm
Merge branch 'main' into typewatch
cdbe93b
* main: (31 commits)
pythongh-95913: Move subinterpreter exper removal to 3.11 WhatsNew (pythonGH-98345)
pythongh-95914: Add What's New item describing PEP 670 changes (python#98315)
Remove unused arrange_output_buffer function from zlibmodule.c. (pythonGH-98358)
pythongh-98174: Handle EPROTOTYPE under macOS in test_sendfile_fallback_close_peer_in_the_middle_of_receiving (python#98316)
pythonGH-98327: Reduce scope of catch_warnings() in _make_subprocess_transport (python#98333)
pythongh-93691: Compiler's code-gen passes location around instead of holding it on the global compiler state (pythonGH-98001)
pythongh-97669: Create Tools/build/ directory (python#97963)
pythongh-95534: Improve gzip reading speed by 10% (python#97664)
pythongh-95913: Forward-port int/str security change to 3.11 What's New in main (python#98344)
pythonGH-91415: Mention alphabetical sort ordering in the Sorting HOWTO (pythonGH-98336)
pythongh-97930: Merge with importlib_resources 5.9 (pythonGH-97929)
pythongh-85525: Remove extra row in doc (python#98337)
pythongh-85299: Add note warning about entry point guard for asyncio example (python#93457)
pythongh-97527: IDLE - fix buggy macosx patch (python#98313)
pythongh-98307: Add docstring and documentation for SysLogHandler.createSocket (pythonGH-98319)
pythongh-94808: Cover `PyFunction_GetCode`, `PyFunction_GetGlobals`, `PyFunction_GetModule` (python#98158)
pythonGH-94597: Deprecate child watcher getters and setters (python#98215)
pythongh-98254: Include stdlib module names in error messages for NameErrors (python#98255)
Improve speed. Reduce auxiliary memory to 16.6% of the main array. (pythonGH-98294)
[doc] Update logging cookbook with an example of custom handling of levels. (pythonGH-98290)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graingertgraingertgraingert left review comments
@gvanrossumgvanrossumgvanrossum approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumaraditya303@bedevere-bot@graingert@gvanrossum