Skip to content

gh-98417: Store int_max_str_digits on the Interpreter State - #98418

Merged
miss-islington merged 1 commit into
python:mainfrom
ericsnowcurrently:int-max-str-runtime-state
Oct 19, 2022
Merged

gh-98417: Store int_max_str_digits on the Interpreter State#98418
miss-islington merged 1 commit into
python:mainfrom
ericsnowcurrently:int-max-str-runtime-state

Conversation

@ericsnowcurrently

@ericsnowcurrentlyericsnowcurrently commented Oct 18, 2022

Copy link
Copy Markdown
Member

Automerge-Triggered-By: GH:ericsnowcurrently

@corona10corona10 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ericsnowcurrently

Copy link
Copy Markdown
MemberAuthor

I'm going to wait for more clarity in GH-98417 before merging this.

@gpsheadgpshead left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this PR regardless of the bug discussion. another PR can add a comment around the PyConfig struct definition about intended use.

@miss-islington
miss-islington merged commit 9c8dde0 into python:mainOct 19, 2022
@ericsnowcurrently
ericsnowcurrently deleted the int-max-str-runtime-state branch October 19, 2022 20:27
carljm added a commit to carljm/cpython that referenced this pull request Oct 20, 2022
* main: (40 commits)
pythongh-98461: Fix source location in comprehensions bytecode (pythonGH-98464)
pythongh-98421: Clean Up PyObject_Print (pythonGH-98422)
pythongh-98360: multiprocessing now spawns children on Windows with correct argv[0] in virtual environments (pythonGH-98462)
CODEOWNERS: Become a typing code owner (python#98480)
[doc] Improve logging cookbook example. (pythonGH-98481)
Add more tkinter.Canvas tests (pythonGH-98475)
pythongh-95023: Added os.setns and os.unshare functions (python#95046)
pythonGH-98363: Presize the list for batched() (pythonGH-98419)
pythongh-98374: Suppress ImportError for invalid query for help() command. (pythongh-98450)
typing tests: `_overload_dummy` raises `NotImplementedError`, not `RuntimeError` (python#98351)
pythongh-98354: Add unicode check for 'name' attribute in _imp_create_builtin (pythonGH-98412)
pythongh-98257: Make _PyEval_SetTrace() reentrant (python#98258)
pythongh-98414: py.exe launcher does not use defaults for -V:company/ option (pythonGH-98460)
pythongh-98417: Store int_max_str_digits on the Interpreter State (pythonGH-98418)
Doc: Remove title text from internal links (python#98409)
[doc] Refresh the venv introduction documentation, and correct the statement about VIRTUAL_ENV (pythonGH-98350)
Docs: Bump sphinx-lint and fix unbalanced inline literal markup (python#98441)
pythongh-92886: Replace assertion statements in `handlers.BaseHandler` to support running with optimizations (`-O`) (pythonGH-93231)
pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `_test_multiprocessing.py` (pythonGH-93233)
pythongh-92886: Fix tests that fail when running with optimizations (`-O`) in `test_py_compile.py` (pythonGH-93235)
...
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

@ericsnowcurrently@gpshead@corona10@bedevere-bot@miss-islington