Skip to content

gh-94473: Flatten arguments in tkinter.Canvas.coords() - #98479

Merged
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:tkinter-canvas-coords-flatten
May 22, 2023
Merged

gh-94473: Flatten arguments in tkinter.Canvas.coords()#98479
serhiy-storchaka merged 4 commits into
python:mainfrom
serhiy-storchaka:tkinter-canvas-coords-flatten

Conversation

@serhiy-storchaka

@serhiy-storchakaserhiy-storchaka commented Oct 20, 2022

Copy link
Copy Markdown
Member

It now accepts not only "x1, y1, x2, y2, ..." and "[x1, y1, x2, y2, ...]", but also "(x1, y1), (x2, y2), ..." and "[(x1, y1), (x2, y2), ...]".

It now accepts not only "x1, y1, x2, y2, ..." and "[x1, y1, x2, y2, ...]",
but also "(x1, y1), (x2, y2), ..." and "[(x1, y1), (x2, y2), ...]".
@Fire-Cube

Copy link
Copy Markdown

I think this is a very good change. I would be very happy if that would be accepted.

@serhiy-storchaka
serhiy-storchaka merged commit 9bc80da into python:mainMay 22, 2023
@serhiy-storchaka
serhiy-storchaka deleted the tkinter-canvas-coords-flatten branch May 22, 2023 08:54
@bedevere-bot

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 Debian root 3.x has failed when building commit 9bc80da.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/345/builds/4871) and take a look at the build logs.
  4. Check if the failure is related to this commit (9bc80da) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/345/builds/4871

Failed tests:

  • test__xxsubinterpreters
  • test_threading

Summary of the results of the build (if available):

==

Click to see traceback logs
remote: Enumerating objects: 30, done. remote: Counting objects: 3% (1/30) remote: Counting objects: 6% (2/30) remote: Counting objects: 10% (3/30) remote: Counting objects: 13% (4/30) remote: Counting objects: 16% (5/30) remote: Counting objects: 20% (6/30) remote: Counting objects: 23% (7/30) remote: Counting objects: 26% (8/30) remote: Counting objects: 30% (9/30) remote: Counting objects: 33% (10/30) remote: Counting objects: 36% (11/30) remote: Counting objects: 40% (12/30) remote: Counting objects: 43% (13/30) remote: Counting objects: 46% (14/30) remote: Counting objects: 50% (15/30) remote: Counting objects: 53% (16/30) remote: Counting objects: 56% (17/30) remote: Counting objects: 60% (18/30) remote: Counting objects: 63% (19/30) remote: Counting objects: 66% (20/30) remote: Counting objects: 70% (21/30) remote: Counting objects: 73% (22/30) remote: Counting objects: 76% (23/30) remote: Counting objects: 80% (24/30) remote: Counting objects: 83% (25/30) remote: Counting objects: 86% (26/30) remote: Counting objects: 90% (27/30) remote: Counting objects: 93% (28/30) remote: Counting objects: 96% (29/30) remote: Counting objects: 100% (30/30) remote: Counting objects: 100% (30/30), done. remote: Compressing objects: 6% (1/16) remote: Compressing objects: 12% (2/16) remote: Compressing objects: 18% (3/16) remote: Compressing objects: 25% (4/16) remote: Compressing objects: 31% (5/16) remote: Compressing objects: 37% (6/16) remote: Compressing objects: 43% (7/16) remote: Compressing objects: 50% (8/16) remote: Compressing objects: 56% (9/16) remote: Compressing objects: 62% (10/16) remote: Compressing objects: 68% (11/16) remote: Compressing objects: 75% (12/16) remote: Compressing objects: 81% (13/16) remote: Compressing objects: 87% (14/16) remote: Compressing objects: 93% (15/16) remote: Compressing objects: 100% (16/16) remote: Compressing objects: 100% (16/16), done. remote: Total 16 (delta 14), reused 1 (delta 0), pack-reused 0 
From https://github.com/python/cpython
* branch main -> FETCH_HEAD
Note: switching to '9bc80dac47f6d43d0bbfbf10c4cc3848b175e97f'.
You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.
If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:
git switch -c <new-branch-name>
Or undo this operation with:
git switch -
Turn off this advice by setting config variable advice.detachedHead to false
HEAD is now at 9bc80dac47 gh-94473: Flatten arguments in tkinter.Canvas.coords() (GH-98479)
Switched to and reset branch 'main'
configure: WARNING: pkg-config is missing. Some dependencies may not be detected correctly.
Fatal Python error: drop_gil: PyMUTEX_LOCK(gil->switch_mutex) failed
Python runtime state: initialized
Thread 0x00007fa56b43e280 (most recent call first):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main
Fatal Python error: Aborted
Thread 0x00007fa56b43e280 (most recent call first):
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 80 in clean_up_interpreters
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/test__xxsubinterpreters.py", line 88 in tearDown
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 594 in _callTearDown
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 637 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/case.py", line 690 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 122 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/suite.py", line 84 in __call__
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/unittest/runner.py", line 240 in run
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1115 in _run_suite
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/support/__init__.py", line 1241 in run_unittest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 294 in _test_module
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 330 in _runtest_inner2
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 373 in _runtest_inner
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 248 in _runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/runtest.py", line 278 in runtest
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 365 in rerun_failed_tests
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 783 in _main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 738 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/libregrtest/main.py", line 802 in main
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/test/__main__.py", line 2 in <module>
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 88 in _run_code
File "/root/buildarea/3.x.angelico-debian-amd64/build/Lib/runpy.py", line 198 in _run_module_as_main
Extension modules: _testcapi, _xxsubinterpreters (total: 2)
Aborted
make: *** [Makefile:1975: buildbottest] Error 134
Cannot open file '/root/buildarea/3.x.angelico-debian-amd64/build/test-results.xml' for upload

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@serhiy-storchaka@Fire-Cube@bedevere-bot