Uh oh!
There was an error while loading. Please reload this page.
gh-98636: Fix detecting gdbm_compat for _dbm module - #98643
Merged
Conversation
mgornyforce-pushed
the
gdbm_compat-98636
branch
from
October 25, 2022 10:28
896c212 to
894ada5Comparemgornyforce-pushed
the
gdbm_compat-98636
branch
from
October 25, 2022 12:03
894ada5 to
72a9700Comparemgorny
commented
Nov 4, 2022
ContributorAuthor
Ping. |
mgorny
commented
Dec 7, 2022
ContributorAuthor
Another ping. It would be really nice to have this fixed. |
mgornyforce-pushed
the
gdbm_compat-98636
branch
from
December 18, 2022 04:44
72a9700 to
7f446f0CompareUh oh!
There was an error while loading. Please reload this page.
Fix the gdbm_compat library detection logic to actually check for -lgdbm_compat independently of the ndbm detection. This fixes the build failure with `--with-dbmliborder=gdbm`, and implicit fallback to ndbm with the default value.
mgornyforce-pushed
the
gdbm_compat-98636
branch
from
December 31, 2022 08:27
7f446f0 to
15510e8Comparemgorny
commented
Dec 31, 2022
ContributorAuthor
@erlend-aasland, updated as requested. |
erlend-aasland
approved these changes
Jan 11, 2023
erlend-aasland
commented
Jan 11, 2023
Contributor
Does this need a backport? |
mgorny
commented
Jan 11, 2023
ContributorAuthor
Unless I'm mistaken, no. The issue was introduced in ec5e253, and FWICS this in 3.12 only. |
erlend-aasland
commented
Jan 11, 2023
Contributor
Thanks, and sorry for the delay! If you want to pursue the AC refactorings discussed, please open an issue/PR. |
mgorny
commented
Jan 12, 2023
ContributorAuthor
Thank you! I'm happy enough having the immediate problem fixed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix the gdbm_compat library detection logic to actually check for
-lgdbm_compat independently of the ndbm detection. This fixes the build
failure with
--with-dbmliborder=gdbm, and implicit fallback to ndbmwith the default value.
--with-dbmliborder=gdbmno longer satisfies_dbm#98636