Skip to content

gh-83004: Clean up refleak in _zoneinfo initialisation - #98842

Merged
JelleZijlstra merged 4 commits into
python:mainfrom
hauntsaninja:gh-83004-zoneinfo
Nov 6, 2022
Merged

gh-83004: Clean up refleak in _zoneinfo initialisation#98842
JelleZijlstra merged 4 commits into
python:mainfrom
hauntsaninja:gh-83004-zoneinfo

Conversation

@hauntsaninja

@hauntsaninjahauntsaninja commented Oct 29, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@JelleZijlstra

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member

Code looks good, but I think we need a NEWS entry as this fixes a (very unlikely) user-facing issue.

@bedevere-botbedevere-bot mentioned this pull request Nov 2, 2022
Closed
@hauntsaninja

hauntsaninja commented Nov 2, 2022

Copy link
Copy Markdown
ContributorAuthor

Added the NEWS entry. If you want to review other changes like this, there's #98840 and #98841

I also went through CPython and about 20 other modules are affected. Should I continue to do single module PRs or can I batch them?

@JelleZijlstra

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
Member

Thanks! I think batching them is fine since the change is simple.

JelleZijlstra
JelleZijlstra reviewed Nov 3, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2022-11-02-05-54-02.gh-issue-83004.0v8iyw.rst Outdated
@JelleZijlstraJelleZijlstra self-assigned this Nov 3, 2022
@JelleZijlstra
JelleZijlstra merged commit 31f2f65 into python:mainNov 6, 2022
@miss-islington

miss-islington commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 6, 2022

Copy link
Copy Markdown
Contributor

Thanks @hauntsaninja for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja@miss-islington
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG…
aadf057
…H-98842)
(cherry picked from commit 31f2f65)
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99163 is a backport of this pull request to the 3.11 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Nov 6, 2022
@bedevere-bot

bedevere-bot commented Nov 6, 2022

Copy link
Copy Markdown

GH-99164 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Nov 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2022
@hauntsaninja@miss-islington
pythongh-83004: Clean up refleak in _zoneinfo initialisation (pythonG…
7cf8db3
…H-98842)
(cherry picked from commit 31f2f65)
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington@hauntsaninja
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842)
4b1e45e
(cherry picked from commit 31f2f65)
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Nov 6, 2022
@miss-islington@hauntsaninja
gh-83004: Clean up refleak in _zoneinfo initialisation (GH-98842)
70006d6
(cherry picked from commit 31f2f65)
Co-authored-by: Shantanu <12621235+hauntsaninja@users.noreply.github.com>
@hauntsaninja
hauntsaninja deleted the gh-83004-zoneinfo branch November 21, 2022 06:59
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra approved these changes
@pgansslepganssleAwaiting requested review from pgansslepganssle is a code owner

Assignees

@JelleZijlstraJelleZijlstra

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hauntsaninja@JelleZijlstra@miss-islington@bedevere-bot