Skip to content

gh-98989: configure: add 3.11 to list of Pythons - #98988

Merged
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:fixconfig
Nov 2, 2022
Merged

gh-98989: configure: add 3.11 to list of Pythons#98988
JelleZijlstra merged 3 commits into
python:mainfrom
JelleZijlstra:fixconfig

Conversation

@JelleZijlstra

@JelleZijlstraJelleZijlstra commented Nov 2, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@JelleZijlstra

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
MemberAuthor

I'll add an issue and NEWS since the bug went out in 3.12a1 and could affect some users.

gvanrossum
gvanrossum approved these changes Nov 2, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't take my word for it, this is probably up to @tiran or @brettcannon to review.

@JelleZijlstraJelleZijlstra changed the title configure: add 3.11 to list of Pythonsgh-98989: configure: add 3.11 to list of PythonsNov 2, 2022
@bedevere-botbedevere-bot mentioned this pull request Nov 2, 2022
Closed
hauntsaninja
hauntsaninja reviewed Nov 2, 2022
View reviewed changes
Comment threadconfigure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

@hauntsaninjahauntsaninjaNov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worth queuing up a couple versions?

@hugovk

hugovk commented Nov 2, 2022

Copy link
Copy Markdown
Member

Something to add to PEP 101 (Doing Python Releases)?

kumaraditya303
kumaraditya303 reviewed Nov 2, 2022
View reviewed changes
Comment threadconfigure.ac

AC_CHECK_PROGS([PYTHON_FOR_REGEN],
[python$PACKAGE_VERSION python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],
[python$PACKAGE_VERSION python3.11 python3.10 python3.9 python3.8 python3.7 python3.6 python3 python],

@kumaraditya303kumaraditya303Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we allowing python3.8 and lower in the first place if we know that 3.9+ is required?

@erlend-aaslanderlend-aaslandNov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 3.9 or higher is required, we should remove the earlier and incompatible versions.

@JelleZijlstraJelleZijlstraNov 2, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Guido said he wanted to remove the 3.9+ dependency that crept into one of the scripts. Increasing the minimum required version might need more discussion as it could make bootstrapping harder for some.

@kumaraditya303kumaraditya303Nov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok sure let's get this in first as this is failing randomly on PRs.

@JelleZijlstraJelleZijlstraNov 2, 2022

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland any objections to landing this?

@erlend-aaslanderlend-aaslandNov 2, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nah, good to good for my part :)

erlend-aasland
erlend-aasland reviewed Nov 2, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxbdB.rst Outdated
@erlend-aaslanderlend-aasland self-assigned this Nov 2, 2022
@JelleZijlstra@erlend-aasland
Update Misc/NEWS.d/next/Build/2022-11-01-21-45-58.gh-issue-98989.tMxb…
3ca0188
…dB.rst
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@JelleZijlstraJelleZijlstra mentioned this pull request Nov 2, 2022
Open
@JelleZijlstra

JelleZijlstra commented Nov 2, 2022

Copy link
Copy Markdown
MemberAuthor

Something to add to PEP 101 (Doing Python Releases)?

python/peps#2864

@JelleZijlstra
JelleZijlstra merged commit f7241aa into python:mainNov 2, 2022
@JelleZijlstra
JelleZijlstra deleted the fixconfig branch November 2, 2022 17:05
@kumaraditya303kumaraditya303 mentioned this pull request Nov 2, 2022
Merged
@JelleZijlstraJelleZijlstra mentioned this pull request Nov 2, 2022
Closed
@gvanrossumgvanrossum mentioned this pull request Nov 2, 2022
Closed
@erlend-aaslanderlend-aasland mentioned this pull request May 14, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja left review comments
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@kumaraditya303kumaraditya303kumaraditya303 left review comments
@gvanrossumgvanrossumgvanrossum approved these changes

Assignees

@erlend-aaslanderlend-aasland

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@JelleZijlstra@hugovk@gvanrossum@hauntsaninja@erlend-aasland@kumaraditya303@bedevere-bot