Uh oh!
There was an error while loading. Please reload this page.
gh-83004: Clean up refleaks in _decimal initialisation - #99043
Closed
hauntsaninja wants to merge 5 commits into
Closed
gh-83004: Clean up refleaks in _decimal initialisation#99043hauntsaninja wants to merge 5 commits into
hauntsaninja wants to merge 5 commits into
Conversation
hauntsaninja
marked this pull request as draft
November 3, 2022 06:44
hauntsaninja
commented
Nov 3, 2022
| extended_context_template)); | ||
| /* Init mpd_ssize_t constants */ |
ContributorAuthor
There was a problem hiding this comment.
Can't add a comment there because Github, but CHECK_INT(PyModule_AddObject(m, ssize_cm->name, obj)); for obj on L6038 does not leak obj on failure because its reference count is 1 going into PyModule_AddObject and we Py_CLEAR it on goto error inside CHECK_INT.
Contributor
There was a problem hiding this comment.
Could you update the PR to add a comment about that?
There was a problem hiding this comment.
Ping on this; there's also a merge conflict.
hauntsaninja
marked this pull request as ready for review
November 3, 2022 07:18
rhettinger
removed their request for review
November 4, 2022 01:27
erlend-aasland
commented
Feb 9, 2024
Contributor
Superseded by Serhiy's #106858. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.