GH-90699: Remove remaining _Py_IDENTIFIER stdlib usage

[kumaraditya303]

• Issue: Replace _Py_IDENTIFIER() with statically initialized objects. #90699

Automerge-Triggered-By: GH:ericsnowcurrently

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[ericsnowcurrently]

LGTM

(Thanks for the changes.)

[ericsnowcurrently]

One small thing and then LGTM.

Also, were you planning on removing _Py_IDENTIFIER() from Programs/_testembed.c? (Presumably we'd drop test_unicode_id_init().) Then again, that should probably be part of the issue/PR that actually eliminates _Py_IDENTIFIER().

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[kumaraditya303]

Then again, that should probably be part of the issue/PR that actually eliminates _Py_IDENTIFIER().

Yeah, will remove that in PR which removes _Py_IDENTIFIER together, no plans for that though.

[ericsnowcurrently]

LGTM

[vstinner]

Refleak buildbots fail since this commit. Example:
https://buildbot.python.org/all/#/builders/217/builds/878

2 tests failed:
test_finalization test_gc

Example:

$ make && ./python -m test -R 3:3 test_finalization -m test_legacy_self_cycle ...
test_finalization leaked [1, 1, 1] references, sum=3
...

cc @pablogsal

[pablogsal]

Please @ericsnowcurrently@kumaraditya303 take a look, otherwise we will need to revert if is not fixed in 24h per our buildbot policy.

[ericsnowcurrently]

If @kumaraditya303 doesn't get to it first, I'll tackle this first thing tomorrow morning (~15 hours from now).

[kumaraditya303]

#99236 fixes the refleak.

[vstinner]

The PR got merged, I confirm that it does fix the issue:

$ ./python -m test -R 3:3 test_gc test_finalization
(...)
Tests result: SUCCESS

[ericsnowcurrently]

Thanks, @kumaraditya303!