Uh oh!
There was an error while loading. Please reload this page.
GH-91375: Port _asyncio static types to heap types and module state - #99122
Conversation
This reverts commit d539152.
bedevere-bot
commented
Nov 5, 2022
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 83d1b54 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
erlend-aasland
left a comment
There was a problem hiding this comment.
Thanks for filling in the missing pieces. Looks good!
We should be able to get rid of module_initialized now that we've got multi-phase init.
Also, the module_free(NULL) at the end of module_init() should now be removed.
(BTW, I added two nit suggestions to clean up some style mess introduced by me.)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
kumaraditya303
commented
Nov 7, 2022
Yes, I thought I had done that but apparently not, might have been messed up in rebasing. Fixed now. |
erlend-aasland
commented
Nov 7, 2022
Kumar: Do you think there's a chance of getting one of the other core devs to do a review? (Andrew or maybe Eric?) |
kumaraditya303
commented
Nov 7, 2022
Andrew is not active ATM because of the war, Eric is busy with the other stuff so I don't think he will have time for this. |
erlend-aasland
commented
Nov 7, 2022
Yeah, I feared that. Do you have a chance to check if there's a performance hit? (I'd be very surprised if there is one.) |
ericsnowcurrently
commented
Nov 7, 2022
I'm going to take a look, but it might not be immediately. |
erlend-aasland
commented
Nov 7, 2022
Great, thanks! |
gvanrossum
left a comment
There was a problem hiding this comment.
Wow, this goes on and on. I'm not sure if anyone could review it -- I'm sure I can't. I am tempted to just trust Erlend, Kumar, the compiler, and the unit test suite, and merge it.
However, there's a merge conflict that needs to be resolved first...
kumaraditya303
commented
Nov 22, 2022
Fixed merge conflict. |
erlend-aasland
commented
Nov 22, 2022
Most of the changes are trivial stuff like passing the module state around to various support and helper functions. |
kumaraditya303
commented
Nov 26, 2022
I am thinking of merging this by next week so that it gets in the next alpha. @ericsnowcurrently If you are not able to review by then, I can do a follow up PR for your review if that's okay with you. |
kumaraditya303
commented
Nov 29, 2022
Merged, thanks @erlend-aasland |
Co-authored-by: Erlend E. Aasland erlend.aasland@protonmail.com