Uh oh!
There was an error while loading. Please reload this page.
gh-81057: Move the Allocators to _PyRuntimeState - #99217
Merged
ericsnowcurrently merged 19 commits intoNov 11, 2022
Merged
Conversation
ericsnowcurrentlyforce-pushed
the
move-allocators-to-runtime-state
branch
from
November 7, 2022 21:31
124ad70 to
02256e9Compareericsnowcurrently
marked this pull request as draft
November 7, 2022 21:33
ericsnowcurrentlyforce-pushed
the
move-allocators-to-runtime-state
branch
2 times, most recently
from
November 8, 2022 01:24
9ab2bfc to
edcd287Compareericsnowcurrentlyforce-pushed
the
move-allocators-to-runtime-state
branch
from
November 8, 2022 18:58
edcd287 to
aa8c9cbCompareericsnowcurrentlyforce-pushed
the
move-allocators-to-runtime-state
branch
from
November 8, 2022 20:46
aa8c9cb to
3172cbeComparebedevere-bot
commented
Nov 9, 2022
🤖 New build scheduled with the buildbot fleet by @ericsnowcurrently for commit 5262207 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
ericsnowcurrently
marked this pull request as ready for review
November 10, 2022 17:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The global allocators were stored in 3 static global variables:
_PyMem_Raw,_PyMem, and_PyObject. State for the "small block" allocator was stored in another 13. That makes a total of 16 global variables. We are moving all 16 to the_PyRuntimeStatestruct as part of the work for gh-81057. (If PEP 684 is accepted then we will follow up by moving them all toPyInterpreterState.)