Skip to content

GH-91095: Specialize calls to normal Python classes. - #99331

Merged
markshannon merged 13 commits into
python:mainfrom
faster-cpython:specialize-calls-to-python-classes
Jun 22, 2023
Merged

GH-91095: Specialize calls to normal Python classes.#99331
markshannon merged 13 commits into
python:mainfrom
faster-cpython:specialize-calls-to-python-classes

Conversation

@markshannon

@markshannonmarkshannon commented Nov 10, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

This is a manual rebase of #93221.

@markshannonmarkshannon mentioned this pull request Nov 10, 2022
Closed
@bedevere-botbedevere-bot mentioned this pull request Nov 10, 2022
Closed
@brandtbucher
brandtbucher self-requested a review November 18, 2022 21:02
This was referenced Nov 18, 2022
Closed
Closed
@pythonpython deleted a comment from netlifyBotMar 10, 2023
brandtbucher
brandtbucher reviewed May 10, 2023
View reviewed changes

@brandtbucherbrandtbucher left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still being considered for 3.13? I think it's one of the last big "important" cases to cover, but if it's too complex right now we can always kick the can down the road a little further...

carljm
carljm reviewed Jun 20, 2023
View reviewed changes
Comment threadPython/bytecodes.c Outdated
Comment threadPython/bytecodes.c
Comment threadPython/bytecodes.c Outdated
Comment threadPython/bytecodes.c Outdated
Comment threadPython/specialize.c Outdated
@markshannon

markshannon commented Jun 21, 2023

Copy link
Copy Markdown
MemberAuthor

Is this still being considered for 3.13?

Yes, should be ready to go now

carljm
carljm approved these changes Jun 21, 2023
View reviewed changes

@carljmcarljm left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM.

@markshannon
markshannon merged commit 04492cb into python:mainJun 22, 2023
bentasker pushed a commit to bentasker/cpython that referenced this pull request Jun 23, 2023
@markshannon@bentasker
pythonGH-91095: Specialize calls to normal Python classes. (pythonGH-…
b12f4ab
…99331)
@markshannon
markshannon deleted the specialize-calls-to-python-classes branch September 26, 2023 12:51
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucherbrandtbucherbrandtbucher left review comments
@carljmcarljmcarljm approved these changes
@iritkatrieliritkatrielAwaiting requested review from iritkatrieliritkatriel is a code owner
@methanemethaneAwaiting requested review from methanemethane is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@markshannon@carljm@brandtbucher@bedevere-bot