Skip to content

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher - #99386

Merged
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:async-deprecate
Nov 12, 2022
Merged

GH-94597: add deprecation warnings for subclassing AbstractChildWatcher#99386
gvanrossum merged 3 commits into
python:mainfrom
kumaraditya303:async-deprecate

Conversation

@kumaraditya303

@kumaraditya303kumaraditya303 commented Nov 11, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-botbedevere-bot mentioned this pull request Nov 11, 2022
Closed
@kumaraditya303

kumaraditya303 commented Nov 11, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

This isn't really needed as deprecation warning will be emitted anyway when configuring the child watcher via set_child_watcher but still adding for anyone who is subclassing this but not configuring the child watcher for whatever reason.

@kumaraditya303kumaraditya303 mentioned this pull request Nov 11, 2022
Closed
gvanrossum
gvanrossum approved these changes Nov 11, 2022
View reviewed changes

@gvanrossumgvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Do double check the appearance of the deprecation note.)

Comment threadDoc/library/asyncio-policy.rst
@gvanrossum
gvanrossum merged commit aa87432 into python:mainNov 12, 2022
@kumaraditya303
kumaraditya303 deleted the async-deprecate branch November 12, 2022 07:18
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@1st11st1Awaiting requested review from 1st11st1 is a code owner
@asvetlovasvetlovAwaiting requested review from asvetlovasvetlov is a code owner

Assignees

No one assigned

Labels

topic-asyncio

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kumaraditya303@gvanrossum@bedevere-bot