Uh oh!
There was an error while loading. Please reload this page.
AC_LANG_SOURCE to AC_LANG_PROGRAM porting - #99407
Closed
thesamesam wants to merge 2 commits into
Closed
Conversation
thesamesamforce-pushed
the
more-clang16-ac_lang_program
branch
from
December 1, 2022 07:29
a42257f to
fad4a9aCompareThis tends to be more readable. Signed-off-by: Sam James <sam@gentoo.org>
thesamesamforce-pushed
the
more-clang16-ac_lang_program
branch
from
December 1, 2022 07:31
fad4a9a to
4a600d1Compareerlend-aasland
commented
May 9, 2023
Contributor
Sorry, I forgot about this. Since last time, I changed my mind (sorry!); I don't think it is worth the churn and risk to change this. The current code works just fine; there is no need to change it. |
ContributorAuthor
No worries at all, I started to feel the same as well actually (that's why I didn't push much for it). Cheers! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As suggested in #99085 (review).
Depends on #99406 for the first commit.