Skip to content

gh-94808: add tests covering PyFunction_{Get,Set}Closure - #99429

Merged
encukou merged 4 commits into
python:mainfrom
sobolevn:cover-pyfunction-closure
Mar 20, 2024
Merged

gh-94808: add tests covering PyFunction_{Get,Set}Closure#99429
encukou merged 4 commits into
python:mainfrom
sobolevn:cover-pyfunction-closure

Conversation

@sobolevn

@sobolevnsobolevn commented Nov 13, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

It was like this:
Снимок экрана 2022-11-13 в 13 00 40

Now all branches are covered.

@bedevere-botbedevere-bot mentioned this pull request Nov 13, 2022
Open
@sobolevnsobolevn added tests Tests in the Lib/test dir skip news labels Nov 13, 2022
kumaraditya303
kumaraditya303 reviewed Nov 26, 2022
View reviewed changes
Comment threadModules/_testcapimodule.c Outdated
Comment on lines +6017 to +6018
Py_INCREF(closure);
return closure;

@kumaraditya303kumaraditya303Nov 26, 2022

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Py_INCREF(closure);
returnclosure;
returnPy_NewRef(closure);

kumaraditya303
kumaraditya303 previously requested changes Nov 26, 2022
View reviewed changes

@kumaraditya303kumaraditya303 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has merge conflicts now.

@bedevere-bot

bedevere-bot commented Nov 26, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@encukou
encukou dismissed kumaraditya303’s stale reviewMarch 19, 2024 15:20

No more merge conflicts

@encukou

encukou commented Mar 19, 2024

Copy link
Copy Markdown
Member

After a year, I took the liberty of updating to the current main branch, and fixed two nitpicks.

@gvanrossum

gvanrossum commented Mar 19, 2024

Copy link
Copy Markdown
Member

Sorry about that. Go ahead and merge!

@sobolevn

sobolevn commented Mar 19, 2024

Copy link
Copy Markdown
MemberAuthor

@encukou thanks a lot for your help! I forgot about this PR a long time ago :)

@encukou
encukou merged commit 8182319 into python:mainMar 20, 2024
@encukou

encukou commented Mar 20, 2024

Copy link
Copy Markdown
Member

No problem, happy to help :)

Usually we backport test changes to reduce future conflicts, but since this already causes conflicts in 3.12, I'll skip the backport here.

vstinner pushed a commit to vstinner/cpython that referenced this pull request Mar 20, 2024
@sobolevn@vstinner
pythongh-94808: add tests coveringPyFunction_{Get,Set}Closure(pyt…
8ca5a2c
…honGH-99429)
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 25, 2024
@sobolevn@adorilson
pythongh-94808: add tests coveringPyFunction_{Get,Set}Closure(pyt…
1cfe1bc
…honGH-99429)
diegorusso pushed a commit to diegorusso/cpython that referenced this pull request Apr 17, 2024
@sobolevn@diegorusso
pythongh-94808: add tests coveringPyFunction_{Get,Set}Closure(pyt…
5950e82
…honGH-99429)
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gvanrossumgvanrossumgvanrossum approved these changes
@kumaraditya303kumaraditya303kumaraditya303 left review comments
@markshannonmarkshannonAwaiting requested review from markshannonmarkshannon is a code owner

Assignees

No one assigned

Labels

skip newstestsTests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn@bedevere-bot@encukou@gvanrossum@kumaraditya303