Uh oh!
There was an error while loading. Please reload this page.
gh-81057: Move the global Dict-Related Versions to _PyRuntimeState - #99497
Merged
ericsnowcurrently merged 4 commits intoNov 16, 2022
Merged
Conversation
ericsnowcurrently
requested review from
a team, markshannon, methane and rhettinger
as code ownersNovember 14, 2022 23:51
ericsnowcurrently
requested review from
carljm and markshannon
and removed request for
a team, markshannon, methane and rhettingerNovember 14, 2022 23:51
methane
reviewed
Nov 16, 2022
Comment on lines
+35
to
+38
| PyDictObject *free_list[PyDict_MAXFREELIST]; | ||
| int numfree; | ||
| PyDictKeysObject *keys_free_list[PyDict_MAXFREELIST]; | ||
| int keys_numfree; |
Member
There was a problem hiding this comment.
How about reorder members to make struct compact?
Suggested change
| PyDictObject*free_list[PyDict_MAXFREELIST]; | |
| intnumfree; | |
| PyDictKeysObject*keys_free_list[PyDict_MAXFREELIST]; | |
| intkeys_numfree; | |
| PyDictObject*free_list[PyDict_MAXFREELIST]; | |
| PyDictKeysObject*keys_free_list[PyDict_MAXFREELIST]; | |
| intnumfree; | |
| intkeys_numfree; |
MemberAuthor
There was a problem hiding this comment.
I don't mind doing that, but it isn't much related to this PR and I was trying to minimize extra changes. That said, it is a fairly small and simple change so I'll go ahead and do it.
methane
approved these changes
Nov 16, 2022
ericsnowcurrentlyforce-pushed
the
consolidate-obj-version-globals
branch
from
November 16, 2022 16:49
5182895 to
f684dcdCompareericsnowcurrently
commented
Nov 16, 2022
MemberAuthor
Thanks for the review, @methane! For a domain-specific change to a complex component like this, it really helps to get an expert review, even if the change seems correct and straight-forward to me. 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We also move the global func version.