Skip to content

gh-99811: Use correct variable to search for asctime - #99812

Merged
vsajip merged 1 commit into
python:mainfrom
cemysce:patch-1
Nov 28, 2022
Merged

gh-99811: Use correct variable to search for asctime#99812
vsajip merged 1 commit into
python:mainfrom
cemysce:patch-1

Conversation

@cemysce

@cemyscecemysce commented Nov 27, 2022•
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@cemysce
cemysce requested a review from vsajip as a code ownerNovember 27, 2022 06:52
@ghost

ghost commented Nov 27, 2022•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-botbedevere-bot mentioned this pull request Nov 27, 2022
Closed
@bedevere-bot

bedevere-bot commented Nov 27, 2022

Copy link
Copy Markdown

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

vsajip
vsajip requested changes Nov 27, 2022
View reviewed changes
Comment threadMisc/NEWS.d/next/Library/2022-11-27-07-00-13.gh-issue-99811.Vi7qsJ.rst Outdated
@bedevere-bot

bedevere-bot commented Nov 27, 2022

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@cemysce
cemysce requested a review from vsajipNovember 27, 2022 07:26
@vsajip
vsajip merged commit 1d1bb95 into python:mainNov 28, 2022
@vsajipvsajip added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Nov 28, 2022
@miss-islington

miss-islington commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @cemysce for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Nov 28, 2022

Copy link
Copy Markdown
Contributor

Thanks @cemysce for the PR, and @vsajip for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Nov 28, 2022

Copy link
Copy Markdown

GH-99851 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@cemysce@miss-islington
pythongh-99811: Use correct variable to search for time in format str…
a2a8946
…ing (pythonGH-99812)
Use correct variable to search for asctime
(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
@bedevere-botbedevere-bot removed the needs backport to 3.11 only security fixes label Nov 28, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 28, 2022
@cemysce@miss-islington
pythongh-99811: Use correct variable to search for time in format str…
0cd04bf
…ing (pythonGH-99812)
Use correct variable to search for asctime
(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
@bedevere-bot

bedevere-bot commented Nov 28, 2022

Copy link
Copy Markdown

GH-99852 is a backport of this pull request to the 3.10 branch.

@bedevere-botbedevere-bot removed the needs backport to 3.10 only security fixes label Nov 28, 2022
@cemysce
cemysce deleted the patch-1 branch November 28, 2022 18:30
vsajip pushed a commit that referenced this pull request Nov 28, 2022
@miss-islington@cemysce
[3.11]gh-99811: Use correct variable to search for time in format st…
5bbf8ed
…ring (GH-99812) (GH-99851)
(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
vsajip pushed a commit that referenced this pull request Nov 28, 2022
@miss-islington@cemysce
[3.10]gh-99811: Use correct variable to search for time in format st…
1b43fa6
…ring (GH-99812) (GH-99852)
(cherry picked from commit 1d1bb95)
Co-authored-by: cemysce <13400533+cemysce@users.noreply.github.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vsajipvsajipvsajip approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cemysce@bedevere-bot@miss-islington@vsajip