Uh oh!
There was an error while loading. Please reload this page.
Reformat "Important Files" section in compiler.rst - #1004
Merged
Conversation
hugovk
reviewed
Dec 9, 2022
Uh oh!
There was an error while loading. Please reload this page.
hugovk
reviewed
Dec 9, 2022
hugovk
left a comment
Member
There was a problem hiding this comment.
Couple more deleted files, the rest look okay.
Otherwise looks good, thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ezio-melotti
commented
Dec 9, 2022
MemberAuthor
The deleted files are tracked in #1003. |
hugovk
approved these changes
Dec 9, 2022
CAM-Gerlach
commented
Dec 9, 2022
Member
If we're reformatting the whole section like this, maybe worth fixing the lexicographic order too while we're at it? |
ezio-melotti
commented
Dec 10, 2022
MemberAuthor
I think they are roughly sorted from most to least important. |
CAM-Gerlach
approved these changes
Dec 15, 2022
CAM-Gerlach
left a comment
Member
There was a problem hiding this comment.
LGTM then, thanks @ezio-melotti
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up of #984 that reformats the "Important Files" section in
compiler.rst:In the PR I added links to the files using
:cpy-file:and reformatted the list.Before:


After: