Skip to content

Update location of the stable_abi.py script - #1103

Merged
encukou merged 1 commit into
python:mainfrom
encukou:sa-loc
May 30, 2023
Merged

Update location of the stable_abi.py script#1103
encukou merged 1 commit into
python:mainfrom
encukou:sa-loc

Conversation

@encukou

@encukouencukou commented May 30, 2023

Copy link
Copy Markdown
Member

Fixes: #1102


📚 Documentation preview 📚: https://cpython-devguide--1103.org.readthedocs.build/

.. code-block:: shell

./python ./Tools/scripts/stable_abi.py --all ./Misc/stable_abi.toml
./python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one still fails on my machine with a fresh build of 3.12 FYI:

> python ./Tools/build/stable_abi.py --all ./Misc/stable_abi.toml
Running Debug|x64 interpreter...
Traceback (most recent call last):
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 757, in <module>
main()
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 723, in main
results['unixy_check'] = do_unixy_check(manifest, args)
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 394, in do_unixy_check
present_macros = gcc_get_limited_api_macros(['Include/Python.h'])
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "C:\Users\alexw\coding\cpython\Tools\build\stable_abi.py", line 526, in gcc_get_limited_api_macros
sysconfig.get_config_var("CC").split()
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'split'

But at least the instructions now point to scripts that actually exist 😆

@encukou

Copy link
Copy Markdown
MemberAuthor

Whoa! I've meant to exclude that on Windows, but apparently I forgot!

(un)fortunately there currently aren't any extra checks to run on Windows, so as a workaround, instead of --all you can:

  • use --generate-all
  • check that git diff is empty

@encukou

Copy link
Copy Markdown
MemberAuthor

Issue: python/cpython#105091

@encukou
encukou merged commit 940cc97 into python:mainMay 30, 2023
@encukou
encukou deleted the sa-loc branch May 30, 2023 13:44
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Instructions for adding a new definition to the limited API don't work on platforms without make

2 participants

@encukou@AlexWaygood