Uh oh!
There was an error while loading. Please reload this page.
Document PGO in devguide - #1153
Conversation
add configure optimization options
add optimization option
option doc add
corona10
commented
Aug 11, 2023
@hugovk@CAM-Gerlach@AlexWaygood Dear reviewers, |
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, it's really useful to document this! This looks pretty good.
Could you maybe start the section with a brief description of why you might or might not want to use this option? I worry that at the moment, people new to Python might think that this is the best option that they should use all the time (since "optimized" is a very positive adjective!)
Maybe the section could start with something like this?
If you are trying to improve the performance of Python, you will probably want to use an optimized build of CPython. It can take a lot longer to build CPython with optimizations enabled, and it's usually not necessary to do so. However, it's essential if you want accurate benchmark results for a proposed performance optimization.
Could you also please wrap each line to 80 characters, like the other paragraphs in this document?
AlexWaygood
commented
Aug 11, 2023
Closing and reopening to retrigger the CLA bot |
Uh oh!
There was an error while loading. Please reload this page.
bfbf2d8 to
5cbed59Compare
corona10
left a comment
There was a problem hiding this comment.
Would you like to update the PR with comments from other reviewers?
KilJaeeun
commented
Aug 13, 2023
@corona10@AlexWaygood |
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks, nearly there! A few more small suggestions below. If you like my suggestions, you can apply them by clicking the "commit suggestion" button below each suggestion :)
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
left a comment
There was a problem hiding this comment.
Depending on how much detail you want to go into, you could link the specific options themselves with :option`python:--enable-optimizations` or :option`python:--with-lto`.
Related, I was a little surprised to see configure options in d.p.o -- thinking about it, should we consider moving it to the devguide? I'm not sure many end-users build their own Python from sources...
A
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
KilJaeeun
commented
Aug 13, 2023
@AlexWaygood
@AA-Turner |
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
left a comment
There was a problem hiding this comment.
Looks good overall! Thanks @KilJaeeun and again congratulations on your first PR!
A
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
AlexWaygood
commented
Aug 13, 2023
Thanks again @KilJaeeun, this was a great first PR! |
Hi! this is my first open source Pull Request in CPython Sprint at PyCon KR so it might be awkward. Added description of enable optimization option. Please take good care of me!

Related issue
I made this PullRequest with these references
📚 Documentation preview 📚: https://cpython-devguide--1153.org.readthedocs.build/