Skip to content

Note when to backport changes - #1169

Merged
hugovk merged 6 commits into
python:mainfrom
JacobCoffee:1168_add_backport_directive
Oct 6, 2023
Merged

Note when to backport changes#1169
hugovk merged 6 commits into
python:mainfrom
JacobCoffee:1168_add_backport_directive

Conversation

@JacobCoffee

@JacobCoffeeJacobCoffee commented Sep 26, 2023

Copy link
Copy Markdown
Member
  • Adds guidelines on what release cycles (where) should get backports of documentation and testing improvements.

Closes

Changes visualized:Dev. CycleVersions

📚 Documentation preview 📚: https://cpython-devguide--1169.org.readthedocs.build/

@AA-TurnerAA-Turner changed the title docs(#1168): add directive on when/where to backport docs and testing changesNote when to backport changesSep 26, 2023
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threadversions.rst Outdated

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this Jacob. I agree with Victor's comments, this needs a few edits in the first instance.

A tip for using admonitions: they stand out and are highlighted, which means that using them must be done sparingly -- when is is most critical for a reader to be aware of a point? I think in this instance, backporting is not of sufficient import; so regular prose is fine. This is very akin to the boy who cried wolf, just in this instance replace the villagers with readers and the wolf with admonitions!

A

Comment threadversions.rst Outdated
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threadversions.rst Outdated
Comment threaddeveloper-workflow/development-cycle.rst Outdated
@JacobCoffee

Copy link
Copy Markdown
MemberAuthor

Thanks Adam, and understood. That makes sense - the use of admonitions is quite a bit different than I am used to 😄

@JacobCoffee

Copy link
Copy Markdown
MemberAuthor

Please re-review at your earliest convenience to see if it is in line with what we want to communicate

Comment threadMakefile Outdated
@JacobCoffee
JacobCoffeeforce-pushed the 1168_add_backport_directive branch from 6a97bbd to 35e855bCompareSeptember 28, 2023 01:15
Comment threaddeveloper-workflow/development-cycle.rst
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threadversions.rst Outdated
Comment threadversions.rst
@AA-Turner

Copy link
Copy Markdown
Member

Please avoid force-pushing, it makes reviewing in the GH interface much harder. PRs are squash merged.

A

Comment threaddeveloper-workflow/development-cycle.rst Outdated
JacobCoffeeand others added 2 commits September 29, 2023 13:48
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Comment threaddeveloper-workflow/development-cycle.rst Outdated
Comment threaddeveloper-workflow/development-cycle.rst Outdated
JacobCoffeeand others added 2 commits October 5, 2023 16:08
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

A

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@JacobCoffee@AA-Turner@vstinner@hugovk