Uh oh!
There was an error while loading. Please reload this page.
Note when to backport changes - #1169
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
left a comment
There was a problem hiding this comment.
Thanks for this Jacob. I agree with Victor's comments, this needs a few edits in the first instance.
A tip for using admonitions: they stand out and are highlighted, which means that using them must be done sparingly -- when is is most critical for a reader to be aware of a point? I think in this instance, backporting is not of sufficient import; so regular prose is fine. This is very akin to the boy who cried wolf, just in this instance replace the villagers with readers and the wolf with admonitions!
A
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
JacobCoffee
commented
Sep 28, 2023
Thanks Adam, and understood. That makes sense - the use of admonitions is quite a bit different than I am used to 😄 |
JacobCoffee
commented
Sep 28, 2023
Please re-review at your earliest convenience to see if it is in line with what we want to communicate |
Uh oh!
There was an error while loading. Please reload this page.
6a97bbd to
35e855bCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
AA-Turner
commented
Sep 28, 2023
Please avoid force-pushing, it makes reviewing in the GH interface much harder. PRs are squash merged. A |
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Closes
Changes visualized:
Dev. Cycle📚 Documentation preview 📚: https://cpython-devguide--1169.org.readthedocs.build/