Skip to content

Add "how to" for the critical_section Argument Clinic directive. - #1217

Merged
AlexWaygood merged 3 commits into
python:mainfrom
colesbury:critical_sections
Nov 14, 2023
Merged

Add "how to" for the critical_section Argument Clinic directive.#1217
AlexWaygood merged 3 commits into
python:mainfrom
colesbury:critical_sections

Conversation

@colesbury

@colesburycolesbury commented Nov 10, 2023•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

@colesburycolesbury mentioned this pull request Nov 10, 2023
Merged
erlend-aasland
erlend-aasland approved these changes Nov 14, 2023
View reviewed changes

@erlend-aaslanderlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

Comment threaddevelopment-tools/clinic.rst Outdated
@AlexWaygood@erlend-aasland
SemBr
6a80036
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
AlexWaygood
AlexWaygood reviewed Nov 14, 2023
View reviewed changes
Comment threaddevelopment-tools/clinic.rst Outdated
Comment threaddevelopment-tools/clinic.rst Outdated
@colesbury@AlexWaygood
Apply suggestions from code review
6df4ecd
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
AlexWaygood
AlexWaygood approved these changes Nov 14, 2023
View reviewed changes

@AlexWaygoodAlexWaygood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@AlexWaygood
AlexWaygood merged commit 679d64b into python:mainNov 14, 2023
@erlend-aasland

erlend-aasland commented Nov 14, 2023

Copy link
Copy Markdown
Contributor

Thanks, everyone!

@colesbury
colesbury deleted the critical_sections branch November 14, 2023 20:38
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@erlend-aaslanderlend-aaslanderlend-aasland approved these changes
@ezio-melottiezio-melottiezio-melotti approved these changes
@AlexWaygoodAlexWaygoodAlexWaygood approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@colesbury@erlend-aasland@hugovk@ezio-melotti@AlexWaygood