Skip to content

Document how to use varargs in Argument Clinic - #1277

Closed
aisk wants to merge 7 commits into
python:mainfrom
aisk:ac-varargs
Closed

Document how to use varargs in Argument Clinic#1277
aisk wants to merge 7 commits into
python:mainfrom
aisk:ac-varargs

Conversation

@aisk

@aiskaisk commented Feb 23, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Member

This is related to python/cpython#64490

📚 Documentation preview 📚: https://cpython-devguide--1277.org.readthedocs.build/

@erlend-aasland
erlend-aasland self-requested a review February 23, 2024 23:48
ezio-melotti
ezio-melotti reviewed Feb 25, 2024
View reviewed changes

@ezio-melottiezio-melotti left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might be higher up in the list.
Should **kwargs be documented too, possibly together with *args?

@aisk

aisk commented Feb 25, 2024

Copy link
Copy Markdown
MemberAuthor

Thanks for the review!

This might be higher up in the list.

Is it ok to move it below How to convert METH_O and METH_NOARGS functions?

Should **kwargs be documented too, possibly together with *args?

According to python/cpython#64490, **kwargs is not supported by Argument Clinic.

@aisk
aisk requested a review from ezio-melottiApril 21, 2024 15:47
@willingc

willingc commented Oct 12, 2024

Copy link
Copy Markdown
Collaborator

@ezio-melotti You have more experience with this tool than I do. Is this PR ready for merge?

@ezio-melotti

ezio-melotti commented Oct 12, 2024

Copy link
Copy Markdown
Member

LGTM. @erlend-aasland?

JelleZijlstra
JelleZijlstra reviewed Oct 13, 2024
View reviewed changes
Comment threaddevelopment-tools/clinic.rst

To convert a var-positional parameter function,
prepending the parameter name with ``*`` ,
and the parameter should use the ``object`` converter::

@JelleZijlstraJelleZijlstraOct 13, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if I use something else? E.g., what if I want to accept an arbitrary number of ints?

Also, what type does the implementation function receive?

@aiskaiskOct 13, 2024

Copy link
Copy Markdown
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the review! I have added a new paragraph to explain more about it.

picnixz
picnixz reviewed Oct 13, 2024
View reviewed changes
Comment threaddevelopment-tools/clinic.rst Outdated
Comment threaddevelopment-tools/clinic.rst
@aisk@JelleZijlstra
Update development-tools/clinic.rst
7d6c9c9
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
@aiskaisk closed this by deleting the head repository Jul 25, 2025
@skirpichevskirpichev mentioned this pull request Aug 12, 2025
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstraJelleZijlstraJelleZijlstra left review comments
@picnixzpicnixzpicnixz left review comments
@willingcwillingcwillingc approved these changes
@erlend-aaslanderlend-aaslandAwaiting requested review from erlend-aasland
@ezio-melottiezio-melottiAwaiting requested review from ezio-melotti

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aisk@willingc@ezio-melotti@JelleZijlstra@picnixz