Skip to content

Add htmllive to make.bat - #1373

Merged
ezio-melotti merged 4 commits into
python:mainfrom
lorenzo-delsignore:add-htmllive-windows
Sep 2, 2024
Merged

Add htmllive to make.bat #1373
ezio-melotti merged 4 commits into
python:mainfrom
lorenzo-delsignore:add-htmllive-windows

Conversation

@lorenzo-delsignore

@lorenzo-delsignorelorenzo-delsignore commented Aug 14, 2024•
edited by github-actions Bot
Loading

Copy link
Copy Markdown
Contributor

This pull request fixes#1366 issue by adding the htmllive command to the make.bat script.

📚 Documentation preview 📚: https://cpython-devguide--1373.org.readthedocs.build/

@ghost

ghost commented Aug 14, 2024•
edited by ghost
Loading

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.
CLA signed

@ezio-melottiezio-melotti self-assigned this Aug 14, 2024
ezio-melotti
ezio-melotti reviewed Aug 14, 2024
View reviewed changes

@ezio-melottiezio-melotti left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can someone on Windows verify that it works as expected?

@ezio-melottiezio-melotti added the type-feature Additions; New content or section needed label Aug 14, 2024
hugovk
hugovk reviewed Aug 14, 2024
View reviewed changes
Comment threadmake.bat Outdated
Comment threadmake.bat Outdated
@lorenzo-delsignore@hugovk
Fix typo
c7129ec
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@lorenzo-delsignore

lorenzo-delsignore commented Aug 14, 2024•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

I think that renaming the variables of SPHINXBUILD and SPHINXAUTOBUILD with something more readable will need a change of the Makefile of Linux too to be consistent. The problem is that the Makefile use only SPHINXBUILD variable, instead with Windows I only found this solution. In my opinion is better to mantain these two variables in the make.bat file.

@hugovk

hugovk commented Aug 14, 2024

Copy link
Copy Markdown
Member

Sure, we can keep the ALLONEWORD ones in this PR. Thanks!

@AA-Turner

AA-Turner commented Aug 15, 2024

Copy link
Copy Markdown
Member

Resolved merge conflicts, given I created them.

A

@ezio-melotti
ezio-melotti merged commit b603868 into python:mainSep 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk left review comments
@ezio-melottiezio-melottiezio-melotti left review comments

Assignees

@ezio-melottiezio-melotti

Labels

type-featureAdditions; New content or section needed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add htmllive target to make.bat

4 participants

@lorenzo-delsignore@hugovk@AA-Turner@ezio-melotti