Skip to content

Move NEWS entries to pull-request-lifecycle - #1506

Merged
hugovk merged 11 commits into
python:mainfrom
StanFromIreland:move-news
Feb 21, 2026
Merged

Move NEWS entries to pull-request-lifecycle#1506
hugovk merged 11 commits into
python:mainfrom
StanFromIreland:move-news

Conversation

@StanFromIreland

@StanFromIrelandStanFromIreland commented Feb 3, 2025•
edited
Loading

Copy link
Copy Markdown
Member

@StanFromIreland

StanFromIreland commented Feb 3, 2025•
edited
Loading

Copy link
Copy Markdown
MemberAuthor

@hugovk@erlend-aasland@AlexWaygood

@StanFromIreland

StanFromIreland commented Feb 3, 2025

Copy link
Copy Markdown
MemberAuthor

See also would be nice but it seems to make the section quoted.

hugovk
hugovk reviewed Feb 3, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See also would be nice but it seems to make the section quoted.

How do you mean?

Comment threadcore-developers/committing.rst Outdated
Comment threadgetting-started/pull-request-lifecycle.rst Outdated
StanFromIrelandand others added 2 commits February 3, 2025 20:48
@StanFromIreland@hugovk
Update core-developers/committing.rst
fbd50f0
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@StanFromIreland
seealso works now?
44024a1
@StanFromIreland

StanFromIreland commented Feb 3, 2025

Copy link
Copy Markdown
MemberAuthor

image

I must have done something weird before it works when I tried again!

hugovk
hugovk approved these changes Feb 3, 2025
View reviewed changes

@hugovkhugovk left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

picnixz
picnixz reviewed Mar 13, 2025
View reviewed changes
Comment threadgetting-started/pull-request-lifecycle.rst Outdated
Comment threadgetting-started/pull-request-lifecycle.rst Outdated
Comment threadgetting-started/pull-request-lifecycle.rst Outdated
Comment threadgetting-started/pull-request-lifecycle.rst Outdated
StanFromIrelandand others added 2 commits March 13, 2025 15:33
@StanFromIreland@picnixz
Apply suggestions from code review
d145ed5
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@StanFromIreland
Benedikts suggestions
11b5c8c
picnixz
picnixz approved these changes Mar 13, 2025
View reviewed changes

@picnixzpicnixz left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We improved a bit the content, but not by much, so it's fine to make it part of this change. I think we need a follow-up PR to improve the cases where a NEWS entry is necessary (see python/cpython#131177 (comment)). OTOH, you can revert the 3.X.rst mention and make it part of the follow-up PR.

Before merging, I'll check that the rst:role is correctly linked though.

@picnixz

picnixz commented Mar 13, 2025

Copy link
Copy Markdown
Member

Arf, it appears that we don't have the cross-referencing:

image

Well, let's introduce intersphinx in a future PR.

@StanFromIreland
Merge branch 'main' into move-news
fb346bc
# Conflicts:
#	core-team/committing.rst
@StanFromIreland

StanFromIreland commented Sep 13, 2025

Copy link
Copy Markdown
MemberAuthor

Closed the originally linked issue as a duplicate of #674

@StanFromIrelandStanFromIreland linked an issue Sep 13, 2025 that may be closed by this pull request
Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb #674
Closed
@StanFromIreland
Merge branch 'main' into move-news
95d1cd0
# Conflicts:
#	core-team/committing.rst
@read-the-docs-community

read-the-docs-communityBot commented Feb 21, 2026

Copy link
Copy Markdown

Documentation build overview

📚 CPython devguide | 🛠️ Build #31500147 | 📁 Comparing 95d1cd0 against latest (b736a43)


🔍 Preview build

Show files changed (13 files in total): 📝 13 modified | ➕ 0 added | ➖ 0 deleted
FileStatus
index.html📝 modified
contrib/index.html📝 modified
core-team/index.html📝 modified
getting-started/index.html📝 modified
versions/index.html📝 modified
contrib/core-team/index.html📝 modified
core-team/committing/index.html📝 modified
getting-started/pull-request-lifecycle/index.html📝 modified
triage/labels/index.html📝 modified
triage/triaging/index.html📝 modified
contrib/core-team/committing/index.html📝 modified
contrib/triage/labels/index.html📝 modified
contrib/triage/triaging/index.html📝 modified

@hugovk
hugovk merged commit 0fe9ca7 into python:mainFeb 21, 2026
5 checks passed
@hugovk

hugovk commented Feb 21, 2026

Copy link
Copy Markdown
Member

Sorry, looks like we forgot about this one! Thanks again!

@StanFromIreland
StanFromIreland deleted the move-news branch February 21, 2026 15:15
@StanFromIreland

StanFromIreland commented Feb 21, 2026

Copy link
Copy Markdown
MemberAuthor

Better late than never, thanks Hugo:-)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovkhugovkhugovk approved these changes
@picnixzpicnixzpicnixz approved these changes
@methanemethaneAwaiting requested review from methane

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sect. 3 (Lifecycle of a Pull Request) does not mention Misc/NEWS.d/next and blurb

3 participants

@StanFromIreland@picnixz@hugovk