Uh oh!
There was an error while loading. Please reload this page.
Overhaul the labels page to reflect current GH labeling practice - #930
Conversation
terryjreedy
commented
Aug 9, 2022
I don't see any mention of automerge in the patch, but see comment on #518. |
ezio-melotti
commented
Aug 11, 2022
I haven't used |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ezio-melotti
commented
Dec 25, 2022
I updated the PR and marked it as "ready for review". It's still not perfect, but we can start merging this and apply further improvements in separate PRs. I left some inline comments to facilitate the review. |
CAM-Gerlach
left a comment
There was a problem hiding this comment.
Thanks @ezio-melotti , this seems like a great set of major and well-needed improvements overall. I did have a number of specific suggestions for tweaks, most minor and a few less so, as well as a handful of broader comments and questions. Thanks!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
hugovk
left a comment
There was a problem hiding this comment.
Thank you for this!
Some suggestions mostly about preserving #anchors where appropriate.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
hugovk
commented
Feb 11, 2023
This PR could also close #296. |
CAM-Gerlach
commented
Feb 14, 2023
It wouldn't let me add that one under |
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM> Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
Uh oh!
There was an error while loading. Please reload this page.
CAM-Gerlach
left a comment
There was a problem hiding this comment.
I had a handful of final followups, ref target label tweaks and a few other fixes I spotted—all as one-click apply able suggestions—plus re-iterating one previous unresolved comment requesting reverting the "assignee" section removal that has no existing replacement, and should be iterated on in the future. Other than that, LGTM, and I resolved the other outstanding comments (aside from a couple addressed here). Thanks @ezio-melotti for all your hard work (and patience) here!
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
CAM-Gerlach
left a comment
There was a problem hiding this comment.
A few final followup fixes and one minor thing I couldn't reach (that may be out of scope), otherwise LGTM, thanks! Marked everything else as resolved now.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: C.A.M. Gerlach <CAM.Gerlach@Gerlach.CAM>
This PR updates the
triage/labels.rstpage, that contained outdated references to removed/renamed labels and previous fields used by bpo.The PR is still a draft. The first commit documents the existing labels. Next, most of the remaining text in the page will either be deleted or moved to other sections, since it mostly covers bpo fields. Finally, I might add more links to the relevant sections to avoid duplicating information.
This is part of CPython labels and will fix the following issues:
Fixes#296
Fixes#518
Fixes#821
Fixes#868
Fixes#929
The structure and grouping of the labels is also based on python/core-workflow#450