Uh oh!
There was an error while loading. Please reload this page.
Add a (small) GDB tips section - #977
Conversation
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
smontanaro
commented
Oct 31, 2022
Thanks for the suggestions @hugovk. I made a comment on one. Do you know how to edit it? |
hugovk
commented
Oct 31, 2022
Yep, done! |
Incorporate feedback from @hugovk to the PR. Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
smontanaro
commented
Nov 1, 2022
This is kind of related to this (by now a bit stale) PR. |
erlend-aasland
left a comment
There was a problem hiding this comment.
Some style nits and suggestions to make things slightly more succinct.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
smontanaro
commented
Nov 2, 2022
Hmmm... The rest of the document seems to differ a bit from what these suggestions indicate. For example, sections about GDB 6 and 7 use "gdb" instead of "GDB". Should I just go through the file and make all the style suggestions in one go? |
smontanaro
commented
Nov 2, 2022
Okay, I screwed up (again). I think I had accepted some earlier suggestions, but not incorporated them locally. Now when I try to push, I get: How do I fix this? |
hauntsaninja
commented
Nov 2, 2022
Maybe something like |
erlend-aasland
commented
Nov 2, 2022
IMO it is better to apply such a change in a separate issue/PR. For this PR, just follow the guidelines. There are some inconsistencies, for example regarding the indent level, but larger parts of the affected file does follow the existing guidelines regarding indent level. |
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
smontanaro
commented
Nov 2, 2022
Took a while, but I finally got things sync'd back up and accepted the various suggestions. |
Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Ezio Melotti <ezio.melotti@gmail.com>
erlend-aasland
commented
Nov 4, 2022
Thanks for this enhancement, Skip! |
This adds a GDB Tips section which describes two (I think) useful features when debugging the virtual machine, saving breakpoints to a file, and setting breakpoints at
TARGET_<INST>labels.