Skip to content

Use a config file. - #143

Merged
JulienPalard merged 20 commits into
python:mainfrom
JulienPalard:config
Oct 17, 2023
Merged

Use a config file.#143
JulienPalard merged 20 commits into
python:mainfrom
JulienPalard:config

Conversation

@JulienPalard

@JulienPalardJulienPalard commented Jan 6, 2023

Copy link
Copy Markdown
Member

Config was previously a bit hidden "in the middle" of the py file. I'd like to use toml but we have a Python 3.8 in production, I'll just wait.

ezio-melotti
ezio-melotti reviewed Jan 11, 2023
View reviewed changes
Comment threadconfig.ini Outdated
@JulienPalard
JulienPalardforce-pushed the config branch 2 times, most recently from ab65eee to 4065817CompareOctober 12, 2023 08:23
@JulienPalardJulienPalard changed the title Use a config file.[WIP] Use a config file.Oct 12, 2023
@JulienPalard

JulienPalard commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

It starts to work but now we lost the info if a release is pointed by a branch or by a tag, which was usefull to git reset to the right release.

@JulienPalard

JulienPalard commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

OK using git show-ref I can easily find the related sha1 of a branch or a tag indiferentely.

I'm running a full build locally before merging.

@JulienPalard

JulienPalard commented Oct 12, 2023

Copy link
Copy Markdown
MemberAuthor

OK I think this one is good, does someone want to review?

@JulienPalardJulienPalard changed the title [WIP] Use a config file.Use a config file.Oct 12, 2023
egeakman
egeakman reviewed Oct 13, 2023
View reviewed changes
Comment threadbuild_docs.py Outdated
AA-Turner
AA-Turner reviewed Oct 14, 2023
View reviewed changes

@AA-TurnerAA-Turner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A brief desk review:

Comment threadbuild_docs.py Outdated
Comment threadbuild_docs.py Outdated
Comment threadbuild_docs.py
Comment threadbuild_docs.py Outdated
Comment threadconfig.toml Outdated
Comment threadbuild_docs.py Outdated
m-aciek
m-aciek approved these changes Oct 14, 2023
View reviewed changes
Comment threadbuild_docs.py Outdated
@JulienPalard

JulienPalard commented Oct 15, 2023

Copy link
Copy Markdown
MemberAuthor

Damned, git show-ref is ambiguous for the main branch as it may have a local existance:

$ git -C /home/mdk/clones/python/docsbuild-scripts/build_root/cpython show-ref main
72b0f0eaf52ac46d5f6e165f737d6f891cf8d172 refs/heads/main
fa18b0afe47615dbda15407a102b84e40cadf6a5 refs/remotes/origin/main

this can't be merged yet.

@JulienPalard
JulienPalard merged commit 03e8f07 into python:mainOct 17, 2023
@JulienPalard
JulienPalard deleted the config branch October 17, 2023 20:19
@JulienPalardJulienPalard mentioned this pull request Oct 21, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-TurnerAA-TurnerAA-Turner left review comments
@ezio-melottiezio-melottiezio-melotti left review comments
+3 more reviewers
@atsuoishimotoatsuoishimotoatsuoishimoto left review comments
@egeakmanegeakmanegeakman left review comments
@m-aciekm-aciekm-aciek approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@JulienPalard@atsuoishimoto@AA-Turner@m-aciek@ezio-melotti@egeakman