type narrowing leads to "unreachable" code being actually reachable

[Akuli]

Bug Report

To Reproduce

class Foo:
 def foo(self) -> None:
 print("Foo!!!")

class Bar:
 def __init__(self) -> None:
 self.foo: Foo | None = Foo()

 def get_rid_of_foo(self) -> None:
 self.foo = None


bar = Bar()
if bar.foo is not None:
 bar.get_rid_of_foo()
 assert bar.foo is None
 print(1 + "lol")

Expected Behavior

An error for the obviously wrong print(1 + "lol"). It fails there at runtime.

Actual Behavior

no errors!

Your Environment

mypy 0.942 with --python-version 3.10

[beauxq]

This is a section of my test suite code (not even a made up example):

 assert not vm.paused
 press_key(pygame.K_SPACE)
 assert vm.paused
 press_key(pygame.K_SPACE, True)
 assert not vm.paused

mypy is reporting unreachable code on the 4th line
That is wrong. That code is reachable and it is executed when I run it.

It is assuming that press_key can't change vm.paused, which is a false assumption.

[beauxq]

re: the "topic-reachability" tag

I think this is more of a type-narrowing issue, rather than reachability.

To narrow types, you have to look at the scope of the name being narrowed (the narrowee), and the scopes of all of the functions called during the narrowed time.
As soon as a function is called that could possibly access the scope of the narrowee, the narrowing is gone.

If someone wants to make sure their type gets narrowed, they can make a local variable, and then only call functions that are defined outside of the local scope.