[1.20 regression] Too aggressive type narrowing with type variables and equality

[kdarnok]

Bug Report

This is about the type narrowing logic updated in 1.20.0: == and in may cause a variable to lose its type: when checked against a type var, these checks cause the lhs variable to assume the type of the rhs. In general the resulting type should probably be some kind of intersection. Without such a construct there are certainly situations where the current behavior might be expected (and it's certainly correct where the variable is of a type that's a supertype of the one checked against), but also where this will be quite confusing.

To Reproduce

from typing import Hashable, TypeVar

H = TypeVar('H', bound=Hashable)

def func(y: H):
 x: int

 assert x == y
 reveal_type(x) # Revealed type is "H"
 x += 1 # Unsupported operand types for + ("H" and "int")

Playground

So, the check causes x to lose its type.

Expected Behavior

No error to be thrown.

Your Environment

• Mypy version used: 1.20.0
• Mypy command-line flags: none
• Mypy configuration options from mypy.ini (and other config files): none
• Python version used: 3.11.12

[ilevkivskyi]

A potential fix may be to update the upper bound of the type variable to be an ad-hoc intersection (i.e. in this case just int, because it is a subtype of Hashable), but @hauntsaninja probably knows better.

[marc-hb]

may cause a variable to lose its type: when checked against a type var, these checks cause the lhs variable to assume the type of the rhs

Not just the lhs, this can affect the rhs too. It seems symetrical?

Reproduction confirmed in zephyrproject-rtos/zephyr#107771 (comment)

import sys
import selectors

sel = selectors.DefaultSelector()
sel.register(sys.stdin, selectors.EVENT_READ)
while True:
 events = sel.select()
 for key, _ in events:

# This passes
 reveal_type(sys.stdin)
 text = sys.stdin.readline()

# After mypy 1.20.x this now fails.
# The type of stdin is now the type of key.fileobj
 if key.fileobj == sys.stdin:
 reveal_type(sys.stdin)
 text = sys.stdin.readline() # "no readline()" warning

# This passes again!
 reveal_type(sys.stdin)
 text = sys.stdin.readline()

[ilevkivskyi]

@marc-hb Your example is a separate story, please open a new issue.

[marc-hb]

I really don't see how this is different, sorry. If I were to open a new issue, it would basically be a duplicate.

(If anyone with the required knowledge opens another issue or PR for my test case, please share the number here)