Signatures of overloaded methods are incompatible with supertypes, even if they really are

[refi64]

e.g.

from typing import overload

class A:
 @overload
 def f(self, x: str) -> str: ...
 @overload
 def f(self, y: int) -> int: ...

class B(A):
 @overload
 def f(self, x: str) -> str: ...
 @overload
 def f(self, y: int) -> int: ...
 @overload
 def f(self, z: bytes) -> bytes: ...

IMO in this case, it should still be compatible, since B supports A's full API, just with another extra function.

[sixolet]

This looks like me, if somebody else doesn't get it first.

…

On Apr 26, 2017, at 9:49 AM, Ryan Gonzalez ***@***.***> wrote: e.g. from typing import overload class A: @overload def f(self, x: str) -> str: ... @overload def f(self, y: int) -> int: ... class B(A): @overload def f(self, x: str) -> str: ... @overload def f(self, y: int) -> int: ... @overload def f(self, z: bytes) -> bytes: ... IMO in this case, it should still be compatible, since B supports A's full API, just with another extra function. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[refi64]

@sixolet I think you might be around 10 seconds too late... ;)

[gvanrossum]

@sixolet Can you review @kirbyfan64's review?

[sixolet]

Yep, though probably tomorrow.

…

On Apr 26, 2017, at 10:27 AM, Guido van Rossum ***@***.***> wrote: @sixolet Can you review @kirbyfan64's review? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

[gvanrossum]

Did this get fixed or not?

[sixolet]

PR [#3263] still out last I checked.