Skip to content

Supporting Ellipsis as a value #7818

Description

@max-sixty

We use an Ellipsis as an easy-to-understand, easy-to-import sentinel value to mean "everything else".

But it's not possible to use fully with type checking, since mypy doesn't exclude it from a type when it's been excluded with an if, as it does for None, or Enums per python/typing#240).

I've included below a MCVE of the behavior below, and here's an example of how we use it, given @gvanrossum has already asked whether it's important to use an Ellipsis:

Details

For example, to transpose an array, these are equivalent:

In [1]: importxarrayasxrIn [2]: ds=xr.tutorial.scatter_example_dataset()
In [3]: dsOut[3]:
<xarray.Dataset>Dimensions: (w: 4, x: 3, y: 11, z: 4)
Coordinates:
*x (x) int64012*y (y) float640.00.10.20.30.40.50.60.70.80.91.0*z (z) int640123*w (w) <U5'one''two''three''five'Datavariables:
A (x, y, z, w) float640.020740.04807-0.1059 ... -0.1809-0.04862B (x, y, z, w) float640.00.00.00.0 ... 1.4061.4141.3681.408In [4]: ds.transpose('w','x','y','z')
Out[4]:
<xarray.Dataset>Dimensions: (w: 4, x: 3, y: 11, z: 4)
Coordinates:
*x (x) int64012*y (y) float640.00.10.20.30.40.50.60.70.80.91.0*z (z) int640123*w (w) <U5'one''two''three''five'Datavariables:
A (w, x, y, z) float640.020740.020740.02074 ... -0.03076-0.04862B (w, x, y, z) float640.00.0020740.004147 ... 1.4031.4051.408In [5]: ds.transpose('w',...) # use an Ellipsis to indicate 'all other dimensions'Out[5]:
<xarray.Dataset>Dimensions: (w: 4, x: 3, y: 11, z: 4)
Coordinates:
*x (x) int64012*y (y) float640.00.10.20.30.40.50.60.70.80.91.0*z (z) int640123*w (w) <U5'one''two''three''five'Datavariables:
A (w, x, y, z) float640.020740.020740.02074 ... -0.03076-0.04862B (w, x, y, z) float640.00.0020740.004147 ... 1.4031.4051.408
  • Are you reporting a bug, or opening a feature request?
    I think it's a bug but Recognize comparison with Ellipsis #2180 suggests it may be a "Will not fix". Wanted to repost it here given the logic above
  • Please insert below the code you are checking with mypy,
    or a mock-up repro if the source is private. We would appreciate
    if you try to simplify your case to a minimal repro.
importbuiltinsfromtypingimportList, Uniondeffun(x: Union[builtins.ellipsis, List], y: List):
ifxisnotEllipsis:
y=x# error: Incompatible types in assignment (expression has type "Union[ellipsis, List[Any]]", variable has type "List[Any]")returny# another attempt:deffun2(x: Union[Ellipsis, List], y: List): # error: Variable "builtins.Ellipsis" is not valid as a typeifxisnotEllipsis:
y=xreturny
  • What is the actual behavior/output?
test.py:7: error: Incompatible types in assignment (expression has type "Union[ellipsis, List[Any]]", variable has type "List[Any]")
test.py:12: error: Variable "builtins.Ellipsis" is not valid as a type
  • What are the versions of mypy and Python you are using?
    Do you see the same issue after installing mypy from Git master?
    mypy 0.740

Thank you!

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions