Uh oh!
There was an error while loading. Please reload this page.
Changes how TypeGuard types are checked in subtypes - #11314
Merged
Conversation
sobolevn
commented
Oct 11, 2021
Uh oh!
There was an error while loading. Please reload this page.
JukkaL
reviewed
Oct 13, 2021
Uh oh!
There was an error while loading. Please reload this page.
sobolevn
commented
Oct 13, 2021
sobolevn
left a comment
MemberAuthor
There was a problem hiding this comment.
Thanks! Now it should be ready.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
hauntsaninja
commented
Oct 30, 2021
Collaborator
Thank you! |
sobolevn
commented
Oct 30, 2021
MemberAuthor
Thanks everyone! |
tushar-deepsource pushed a commit
to DeepSourceCorp/mypy
that referenced
this pull request
Jan 20, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now two functions are not considered subtypes if:
TypeGuard, other returnsbool. We respect subtyping direction here.TypeGuardis considered to be subtype ofboolTypeGuard[int], second returnsTypeGuard[str]Closes#11307