Skip to content

Attempt to fix bool re-narrowing - #11845

Closed
sobolevn wants to merge 3 commits into
python:masterfrom
sobolevn:issue-11839
Closed

Attempt to fix bool re-narrowing#11845
sobolevn wants to merge 3 commits into
python:masterfrom
sobolevn:issue-11839

Conversation

@sobolevn

@sobolevnsobolevn commented Dec 25, 2021

Copy link
Copy Markdown
Member

Let's see what mypy_primer and CI will say.

Closes#11839
Refs #10389

@github-actions

This comment has been minimized.

@sobolevn

sobolevn commented Dec 25, 2021

Copy link
Copy Markdown
MemberAuthor

For some reason all builds with mypyc-compiled mypy fail. While regular tests pass. No idea why.

@github-actions

This comment has been minimized.

@sobolevn

Copy link
Copy Markdown
MemberAuthor

Ok, I will try something else.

@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

graphql-core (https://github.com/graphql-python/graphql-core)
+ tests/type/test_definition.py:1115: error: Argument 1 to "isnan" has incompatible type "None"; expected "Union[SupportsFloat, SupportsIndex]"+ tests/language/test_visitor.py:73: error: Value of type "Node" is not indexable
zulip (https://github.com/zulip/zulip)
+ zerver/lib/events.py:495: error: Statement is unreachable [unreachable]+ zerver/lib/events.py:513: error: Statement is unreachable [unreachable]+ zerver/lib/events.py:534: error: Statement is unreachable [unreachable]+ zerver/lib/events.py:600: error: Statement is unreachable [unreachable]+ zerver/tests/test_events.py:495: error: Statement is unreachable [unreachable]
core (https://github.com/home-assistant/core)
- homeassistant/config_entries.py:474: error: Returning Any from function declared to return "bool" [no-any-return]

@sobolevn

Copy link
Copy Markdown
MemberAuthor

See #11839 (comment)

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression with type narrowing of bool

1 participant

@sobolevn