Uh oh!
There was an error while loading. Please reload this page.
propertize Callable attributes before freezing dataclasses - #12383
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
uSpike
commented
Mar 21, 2022
ContributorAuthor
I need to rethink this because this does not raise an error when a frozen dataclass Callable method is mutated. |
uSpike
commented
Mar 21, 2022
ContributorAuthor
OK I think I've fixed it so that propertized callables are not writable when frozen. This PR should be ready for review |
uSpike
commented
Mar 21, 2022
ContributorAuthor
Fixed linting error |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
jhance
commented
Mar 23, 2022
Collaborator
Needs a rebase then I will merge. |
JelleZijlstra
commented
Mar 23, 2022
Member
I fixed the merge conflict |
Contributor
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #12312
Related: #10292
Callableattributes of afrozen=Truedataclass were not being handled correctly:Callableattributes were being propertized if the dataclass was not frozen.This change will always propertize
Callableattributes before optionally freezing attributes in the dataclass plugin.Test Plan
Added a test for Callable types in a frozen dataclass to
test-data/unit/check-dataclasses.test