Skip to content

Add test cases for method property overrides#13503

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hauntsaninja merged 1 commit into from
Aug 25, 2022
Merged

Add test cases for method property overrides #13503

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test-data/unit/check-classes.test
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7457,3 +7457,23 @@ class Bar(Foo):
@x.setter
def x(self, value: int) -> None: ...
[builtins fixtures/property.pyi]

[case testOverrideMethodProperty]
class B:
def foo(self) -> int:
...
class C(B):
@property
def foo(self) -> int: # E: Signature of "foo" incompatible with supertype "B"
...
[builtins fixtures/property.pyi]

[case testOverridePropertyMethod]
class B:
@property
def foo(self) -> int:
...
class C(B):
def foo(self) -> int: # E: Signature of "foo" incompatible with supertype "B"
...
[builtins fixtures/property.pyi]