Skip to content

mypy_primer: truncate per-project output - #14091

Merged
hauntsaninja merged 3 commits into
python:masterfrom
ikonst:2022-11-14-mypy_primer_per_project_limit
Nov 18, 2022
Merged

mypy_primer: truncate per-project output#14091
hauntsaninja merged 3 commits into
python:masterfrom
ikonst:2022-11-14-mypy_primer_per_project_limit

Conversation

@ikonst

@ikonstikonst commented Nov 14, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

Closes#14059.

@github-actions

This comment has been minimized.

Sign in to view
@ikonst
ikonstforce-pushed the 2022-11-14-mypy_primer_per_project_limit branch from b8d1849 to bebf0adCompareNovember 14, 2022 17:34
@github-actions

This comment has been minimized.

Sign in to view
@ikonst

ikonst commented Nov 14, 2022

Copy link
Copy Markdown
ContributorAuthor

Hmm, that's not right... ^

@AlexWaygood

AlexWaygood commented Nov 14, 2022•
edited
Loading

Copy link
Copy Markdown
Member

I think maybe the last commit didn't trigger mypy_primer at all, due to the fact that there's now a merge conflict :)

@ikonst

ikonst commented Nov 14, 2022

Copy link
Copy Markdown
ContributorAuthor

So it didn't trigger the primer run but triggered the merging?

@ikonst

ikonst commented Nov 14, 2022

Copy link
Copy Markdown
ContributorAuthor

OK, conflict was in tests, resolved the conflict in some random way.

@github-actions

This comment has been minimized.

Sign in to view
@hauntsaninja

hauntsaninja commented Nov 14, 2022

Copy link
Copy Markdown
Collaborator

IIRC you're not going to be able to test this in a PR to mypy, unfortunately. The comment workflow requires additional perms, so I believe it doesn't actually run the code in this PR. You could get it to run on your fork though!

@ikonst

ikonst commented Nov 14, 2022•
edited
Loading

Copy link
Copy Markdown
ContributorAuthor

@hauntsaninja Thanks for the tip, makes perfect sense. I'm only starting to grok the security model of Actions.

Let's try: ikonst#1

@ikonst

ikonst commented Nov 15, 2022

Copy link
Copy Markdown
ContributorAuthor

@hauntsaninja tested here

@ikonst
ikonstforce-pushed the 2022-11-14-mypy_primer_per_project_limit branch from d00fa42 to 15eeecdCompareNovember 15, 2022 15:48
@github-actions

github-actionsBot commented Nov 15, 2022

Copy link
Copy Markdown
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@ikonst

ikonst commented Nov 18, 2022

Copy link
Copy Markdown
ContributorAuthor

@hauntsaninja 👋

hauntsaninja
hauntsaninja approved these changes Nov 18, 2022
View reviewed changes

@hauntsaninjahauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

Comment thread.github/workflows/mypy_primer_comment.yml Outdated
@hauntsaninja
hauntsaninja merged commit abb5a80 into python:masterNov 18, 2022
@ikonst
ikonst deleted the 2022-11-14-mypy_primer_per_project_limit branch November 18, 2022 05:58
@ikonstikonst mentioned this pull request Apr 11, 2023
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Truncating mypy_primer output per project

3 participants

@ikonst@AlexWaygood@hauntsaninja