Uh oh!
There was an error while loading. Please reload this page.
Rename unreachable_lines to skipped_lines - #15483
Merged
Merged
Conversation
ikonstforce-pushed
the
06-20-rename-reachability
branch
from
June 21, 2023 00:18
7b3c35a to
62df7bbCompare
This comment has been minimized.
This comment has been minimized.
ilevkivskyi
approved these changes
Jun 21, 2023
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, but there are small comments.
| # Lines that are statically unreachable (e.g. due to platform/version check). | ||
| unreachable_lines: dict[str, set[int]] | ||
| # Lines that were skipped during semantic analysis (would not be type-checked). |
Member
There was a problem hiding this comment.
Please keep the examples of a reason to skip: e.g. due to platform/version check
| ignored_lines: dict[int, list[str]] | ||
| # Lines that are statically unreachable (e.g. due to platform/version check). | ||
| unreachable_lines: set[int] | ||
| # Lines that were skipped during semantic analysis (would not be type-checked). |
Member
There was a problem hiding this comment.
Please keep the examples of a reason to skip: e.g. due to platform/version check
Contributor
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #15164 we've made it so that
# type: ignores in lines skipped in semantic analysis would not be flagged as unused.In #15164 they were called "unreachable" lines but unreachability during type-checking can result in the "Statement is unreachable" error, while these statements are pruned before type-checking, so for clarity we'll use the term "skipped".