Skip to content

Update math error messages for 3.14 - #18534

Merged
JukkaL merged 1 commit into
python:masterfrom
cdce8p:mypyc-math
Jan 27, 2025
Merged

Update math error messages for 3.14#18534
JukkaL merged 1 commit into
python:masterfrom
cdce8p:mypyc-math

Conversation

@cdce8p

Copy link
Copy Markdown
Collaborator

The error messages for some math functions got changed in python/cpython#124299. Adjust mypyc to emit the same ones.

Fixes mypyc/test/test_run.py::TestRun::run-math.test::testMathOps

@cdce8pcdce8p added the topic-mypyc mypyc bugs label Jan 26, 2025

@JukkaLJukkaL left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@JukkaL
JukkaL merged commit 065c8fa into python:masterJan 27, 2025
@cdce8p
cdce8p deleted the mypyc-math branch January 27, 2025 10:16
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
The error messages for some math functions got changed in
python/cpython#124299. Adjust mypyc to emit the
same ones.
Fixes `mypyc/test/test_run.py::TestRun::run-math.test::testMathOps`
hauntsaninja pushed a commit that referenced this pull request Apr 22, 2025
Followup to #18534
Some more error messages for math functions were changed for Python
3.14, see python/cpython#129497.
Fixes `mypyc/test/test_run.py::TestRun::run-math.test::testMathOps`
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

topic-mypycmypyc bugs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@cdce8p@JukkaL