Skip to content

Add option to selectively disable deprecation warnings - #18641

Merged
hauntsaninja merged 1 commit into
python:masterfrom
cdce8p:deprecated-calls-exclude
Feb 10, 2025
Merged

Add option to selectively disable deprecation warnings#18641
hauntsaninja merged 1 commit into
python:masterfrom
cdce8p:deprecated-calls-exclude

Conversation

@cdce8p

@cdce8pcdce8p commented Feb 9, 2025•
edited
Loading

Copy link
Copy Markdown
Collaborator

Suggested in #18192 (comment)

Fixes#18435

@cdce8pcdce8p added the topic-pep-702 PEP 702, @deprecated label Feb 9, 2025
@cdce8p
cdce8p requested a review from tyrallaFebruary 9, 2025 13:35
@github-actions

github-actionsBot commented Feb 9, 2025

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

django-stubs (https://github.com/typeddjango/django-stubs): 1.44x faster (35.2s -> 24.4s in a single noisy sample)

@cdce8pcdce8p added the topic-configuration Configuration files and flags label Feb 9, 2025
tyralla
tyralla approved these changes Feb 9, 2025
View reviewed changes

@tyrallatyralla left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for implementing this! I think it should close #18435. I only left a very minor remark.

Comment threaddocs/source/config_file.rst
Selectively excludes functions and methods defined in specific packages,
modules, and classes from the :ref:`deprecated<code-deprecated>` error code.
This also applies to all submodules of packages (i.e. everything inside
a given prefix). Note, this option does not support per-file configuration,

@tyrallatyrallaFeb 9, 2025

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe end with ";" instead of ","?

@cdce8pcdce8pFeb 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tbh I mostly copied the contents from the untyped_calls_exclude option. So I'd leave it as is. https://mypy.readthedocs.io/en/stable/config_file.html#confval-untyped_calls_exclude

@cdce8p

cdce8p commented Feb 9, 2025•
edited
Loading

Copy link
Copy Markdown
CollaboratorAuthor

Thanks for implementing this! I think it should close #18435.

Yeah, added it to the PR description.

Btw. I'm open to suggestion for a better option name. deprecated_calls_exclude works but doesn't sound that good IMO. Although I suspect it's primarily going to be used in config files, so it might not matter much.

hauntsaninja
hauntsaninja approved these changes Feb 9, 2025
View reviewed changes

@hauntsaninjahauntsaninja left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, want to make a changelog entry as well?

@cdce8p

cdce8p commented Feb 9, 2025

Copy link
Copy Markdown
CollaboratorAuthor

Cool, want to make a changelog entry as well?

Yeah, let's do that in a followup if that's all right. I've a few more topics in mind for already merged PRs. E.g. different property getter / setter types, stubgen decorator improvements, mypyc support for frozenset.

@hauntsaninja
hauntsaninja merged commit f74f818 into python:masterFeb 10, 2025
@cdce8p
cdce8p deleted the deprecated-calls-exclude branch February 10, 2025 11:03
@cdce8pcdce8p mentioned this pull request Feb 10, 2025
Merged
hauntsaninja pushed a commit that referenced this pull request Feb 11, 2025
@cdce8p
Add initial changelog for 1.16 (#18652)
f7f6bc2
Create changelog entries for
- #18510
- #18641
ericmarkmartin pushed a commit to ericmarkmartin/mypy that referenced this pull request Feb 19, 2025
@cdce8p@ericmarkmartin
Add initial changelog for 1.16 (python#18652)
7e49f32
Create changelog entries for
- python#18510
- python#18641
ericmarkmartin pushed a commit to ericmarkmartin/mypy that referenced this pull request Feb 19, 2025
@cdce8p@ericmarkmartin
Add initial changelog for 1.16 (python#18652)
f5da233
Create changelog entries for
- python#18510
- python#18641
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
@cdce8p@x612skm
Add option to selectively disable deprecation warnings (python#18641)
9cb908c
Suggested in
python#18192 (comment)Fixespython#18435
x612skm pushed a commit to x612skm/mypy-dev that referenced this pull request Feb 24, 2025
@cdce8p@x612skm
Add initial changelog for 1.16 (python#18652)
57b5e2f
Create changelog entries for
- python#18510
- python#18641
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hauntsaninjahauntsaninjahauntsaninja approved these changes
+1 more reviewer
@tyrallatyrallatyralla approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

topic-configurationConfiguration files and flagstopic-pep-702PEP 702, @deprecated

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support package ignores for deprecated

3 participants

@cdce8p@hauntsaninja@tyralla