Uh oh!
There was an error while loading. Please reload this page.
Enable colored output for argparse help in Python 3.14 - #19021
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
sterliakov
left a comment
There was a problem hiding this comment.
This certainly looks nice! Are we sure these changes will be present in final 3.14 release? As usual, there's some chance that unreleased functionality may be removed/renamed/significantly altered.
cdce8p
commented
May 4, 2025
There is always the possibility that a new feature gets reverted before the final release, though I don't suspect it happening here. Nevertheless if that should happen, a lot of test cases would fail with 3.14 at which point we could just revert this one. |
hamdanal
left a comment
There was a problem hiding this comment.
Thanks for adding this, I think it is a huge readability upgrade to have colors in the help text of a CLI (the reason I proposed #14455 earlier). I have two suggestions for this change:
- Please also change
dmypy,stubgenandstubtestparsers - Instead of branching on the python version and passing a keywords dictionary, set the
colorattribute on the parser instance after initialization, as it is recommended in the argparse documentation.
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
…" (#19721) Reverts #19021 After the PR was merged, `color` was changed to `true` for Python 3.14. Setting it manually is no longer necessary. python/cpython#136809https://docs.python.org/3.14/library/argparse.html#color
Support for colored output was just merged in cpython. Maybe a bit early to add it here already but it doesn't hurt either.
The color output can be disable using various environment variables.
https://docs.python.org/3.14/using/cmdline.html#using-on-controlling-color