Skip to content

Fix crash on invalid property inside its own body - #19208

Merged
hauntsaninja merged 1 commit into
python:masterfrom
ilevkivskyi:fix-double-invalid-property
Jun 3, 2025
Merged

Fix crash on invalid property inside its own body#19208
hauntsaninja merged 1 commit into
python:masterfrom
ilevkivskyi:fix-double-invalid-property

Conversation

@ilevkivskyi

Copy link
Copy Markdown
Member

Fixes#19205

@ilevkivskyi
ilevkivskyi requested a review from JukkaLJune 2, 2025 17:41
@github-actions

Copy link
Copy Markdown
Contributor

Diff from mypy_primer, showing the effect of this PR on open source code:

nox (https://github.com/wntrblm/nox): 1.17x slower (43.1s -> 50.6s in single noisy sample)
typeshed-stats (https://github.com/AlexWaygood/typeshed-stats): 1.23x slower (46.0s -> 56.5s in single noisy sample)

@ilevkivskyiilevkivskyi mentioned this pull request Jun 3, 2025
@hauntsaninja
hauntsaninja merged commit 5727d33 into python:masterJun 3, 2025
@ilevkivskyi
ilevkivskyi deleted the fix-double-invalid-property branch June 3, 2025 12:41
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[1.16 regression] crashes on invalid and self-referential setter

2 participants

@ilevkivskyi@hauntsaninja