Uh oh!
There was an error while loading. Please reload this page.
Further improve match statement narrowing against unions - #20744
Merged
Conversation
I realised there is a simpler and more powerful approach than the one taken in python#19600. This basically adds the new "Step 2" to the original code.
This comment has been minimized.
This comment has been minimized.
hauntsaninja
marked this pull request as draft
February 5, 2026 08:24
This comment has been minimized.
This comment has been minimized.
JukkaL
approved these changes
Feb 11, 2026
JukkaL
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, looks good -- just one potential code path that seems redundant.
| elif isinstance(current_type, AnyType): | ||
| inner_type: Type = AnyType(TypeOfAny.from_another_any, current_type) | ||
| inner_types = [inner_type] * len(o.patterns) | ||
| elif isinstance(current_type, TupleType): |
Collaborator
There was a problem hiding this comment.
Second check against TupleType that can never be taken?
Contributor
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
Uh oh!
There was an error while loading. Please reload this page.
This was referenced Feb 25, 2026
hauntsaninja added a commit
that referenced
this pull request
Mar 4, 2026
Fixes#18950 Fixes this comment #19081 (comment) (previously improved on by #20744 and #20782 )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I realised there is a simpler and more complete approach than the one taken in #19600.
This adds the new "Step 2" to the original code. Best way to review the diff is probably to check it out and review it squashed with #19600 , but really the net logic change is just "Step 2"
Fixes#15190
Fixes#17549
Fixes#17600
Mostly fixes#18039
Helps with things in #19081