Skip to content

Update changelog for narrowing changes - #21006

Merged
hauntsaninja merged 3 commits into
python:masterfrom
hauntsaninja:narrowchange
Mar 11, 2026
Merged

Update changelog for narrowing changes#21006
hauntsaninja merged 3 commits into
python:masterfrom
hauntsaninja:narrowchange

Conversation

@hauntsaninja

@hauntsaninjahauntsaninja commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Closes#20564

@hauntsaninjahauntsaninja mentioned this pull request Mar 11, 2026
Closed
brianschubert
brianschubert reviewed Mar 11, 2026
View reviewed changes
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
Comment threadCHANGELOG.md Outdated
@hauntsaninja@brianschubert
Apply suggestions from code review
ebcdb20
Co-authored-by: Brian Schubert <brianm.schubert@gmail.com>
A5rocks
A5rocks approved these changes Mar 11, 2026
View reviewed changes

@A5rocksA5rocks left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me, just checking my knowledge.

Comment threadCHANGELOG.md Outdated
hauntsaninja
hauntsaninja commented Mar 11, 2026
View reviewed changes
Comment threadCHANGELOG.md Outdated
@hauntsaninja
hauntsaninja merged commit 537740b into python:masterMar 11, 2026
2 checks passed
@hauntsaninja
hauntsaninja deleted the narrowchange branch March 11, 2026 21:55
@A5rocks

A5rocks commented Mar 11, 2026•
edited
Loading

Copy link
Copy Markdown
Collaborator

Looks like you accidentally switched the line endings! (well, GitHub did. I wonder why!)

@hauntsaninja

hauntsaninja commented Mar 11, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Wait, that's extremely weird

@hauntsaninja

hauntsaninja commented Mar 11, 2026

Copy link
Copy Markdown
CollaboratorAuthor

Especially since applying Brian's suggestions in the Github UI didn't change line endings

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@brianschubertbrianschubertbrianschubert left review comments
@A5rocksA5rocksA5rocks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Better narrowing

3 participants

@hauntsaninja@A5rocks@brianschubert