Uh oh!
There was an error while loading. Please reload this page.
Support user install on Windows. - #4005
Conversation
On Windows, the usual install paths are sys.prefix/Lib/mypy for a global install. For user installs, the path is site.getuserbase()/lib/mypy. We also fall back to the old method of installation due to the data dir being put in the package directory on an egg install.
gvanrossum
left a comment
There was a problem hiding this comment.
Can you get rid of the map() call? It looks too clever an I don't trust it.
emmatyping
commented
Sep 25, 2017
Removed. Mypy wasn't happy with the map call either. |
gvanrossum
left a comment
There was a problem hiding this comment.
I'd make prefixes a list. I'll wait until I can test it myself.
emmatyping
commented
Sep 25, 2017
The Appveyor failure was the usual #3895 |
ilevkivskyi
left a comment
There was a problem hiding this comment.
I just tried this PR on Linux, everything works.
gvanrossum
left a comment
There was a problem hiding this comment.
OK, once AppVeyor passes I'll merge (or you may).
Summertime
commented
Sep 26, 2017
Seems like it fixed the issue I was having, works for me! |
davt
commented
Oct 18, 2017
Be aware that this change as shipped in 0.530 (installed from pypi) breaks when run under virtualenv on Windows. The underlying reason is that - for reasons I don't understand - virtualenv overwrites Lib/site.py with an old version which does not include the function site.getuserbase(). Would a direct call to sysconfig.get_config_var('userbase') be a suitable workaround? |
JukkaL
commented
Oct 18, 2017
@davt Can you file a new issue for the virtualenv-on-Windows problem? |
On Windows, the usual install paths are
sys.prefix/Lib/mypyfor a globalinstall. For user installs, the path is
site.getuserbase()/lib/mypy. Wealso fall back to the old method of installation due to the data dir being
put in the package directory on an egg install.
This restores the usual data directory resolution on other platforms.
Correctly fixes#3988, and keeps other platforms working.