Uh oh!
There was an error while loading. Please reload this page.
Add a py.typed marker, per PEP 561 - #4255
Conversation
ilevkivskyi
commented
Jan 19, 2018
Does this mean that PEP 561 will not go into 3.7? |
gvanrossum
commented
Jan 19, 2018
Must have been a side-effect of prematurely cleaning out the branch. FWIW I don't believe that there is any effect of PEP 561 on CPython, so I don't consider this urgent. IIUC @ethanhs is still working on his implementation -- I'd like to play around with that before finalizing acceptance of his PEP (I believe he revised the PEP at least once as a result of something he encountered during implementation). |
emmatyping
commented
Jan 19, 2018
Agreed, it doesn't need to be accepted before 3.7 lands.
Yes I am afraid I haven't had much time in the last month to work on it (or much of anything), but I hope to get back to it more this weekend. |
Now that #4693 is merged |
gvanrossum
commented
Apr 9, 2018
Whoops pilot error. Will fix. |
gvanrossum
commented
Apr 9, 2018
Actually I was very thorough in my misguided scrubbing of this branch. @ethanhs do you still have a copy? |
|
gvanrossum
commented
Apr 9, 2018
OK, new one is in $4879. Is there a reason not to merge this in 0.590? |
emmatyping
commented
Apr 9, 2018
I don't think so, no. |
gvanrossum
commented
Apr 9, 2018
Hm, then why did you say previously "This should wait for the PEP to be accepted"? (IIUC you even edited your comment to strike through "I believe this can be merged too?" and add that.) |
emmatyping
commented
Apr 9, 2018
You had said it should wait for the PEP to be accepted in the original comment. I have no reason to wait, so it's up to you. Apologies for the confusion. |
(Might want to wait merging this until PEP 561 is accepted.)