Uh oh!
There was an error while loading. Please reload this page.
Namespace packages (PEP 420) - #5691
Conversation
f2c87ff to
ecac1b5Compare
gvanrossum
commented
Sep 29, 2018
(Whoops, accidentally deleted the branch which caused the PR to be closed. I'm not done yet.) |
ilevkivskyi
left a comment
There was a problem hiding this comment.
I think this is right. At least after reading the PEP and playing a bit, this coincides with the runtime behaviour. I have two more suggestions for tests (apart from nesting normal in namespace and vice versa as you proposed, I just checked, both of these work at runtime).
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ilevkivskyi
commented
Oct 1, 2018
As I understand this fixes #1645. I would add it to the PR description, so that we will not forget to close the issue :) |
gvanrossum
commented
Oct 1, 2018
Alas, tests for nesting one type of package inside the other fail (both ways -- it always prefers the decoy file). It's late so I'll just leave it broken, I'll fix it tomorrow. |
gvanrossum
commented
Oct 1, 2018
Hey @carljm, IIRC you expressed interest in namespace packages eons ago. Perhaps you can test this PR with your use case? |
gvanrossum
commented
Oct 2, 2018
(Hold on, I have an idea for a refinement of the final part of the algorithm.) |
gvanrossum
commented
Oct 2, 2018
@ilevkivskyi I think I'm happy now. Are you? |
| # indicates the highest level at which a __init__.py[i] file | ||
| # is found; if no __init__ was found it returns 0, if we find | ||
| # only foo/bar/__init__.py it returns 1, and if we have | ||
| # foo/__init__.py it returns 2 (regardless of what's un |
Tentative implementation of PEP 420. Fixespython#1645. Clarification of the implementation: - `candidate_base_dirs` is a list of `(dir, verify)` tuples, laboriously pre-computed. - The old code just looped over this list, looking for `dir/<module>`, and if found, it would verify that there were `__init__.py` files in all the right places (except if `verify` is false); the first success would be the hit; - In PEP 420 mode, if the above approach finds no hits, we do something different for those paths that failed due to `__init__` verification; essentially we narrow down the list of candidate paths by checking for `__init__` files from the top down. Hopefully the last test added clarifies this.
Tentative implementation of PEP 420. Fixes#1645.
Clarification of the implementation:
candidate_base_dirsis a list of(dir, verify)tuples, laboriously pre-computed.dir/<module>, and if found, it would verify that there were__init__.pyfiles in all the right places (except ifverifyis false); the first success would be the hit;__init__verification; essentially we narrow down the list of candidate paths by checking for__init__files from the top down. Hopefully the last test added clarifies this.