Uh oh!
There was an error while loading. Please reload this page.
Don't crash if module shadows special library module such as "typing" - #8405
Merged
Conversation
Special cases a small set of modules so that they must be defined in typeshed, as otherwise it's likely that mypy can crash, as it assumes that various things are defined in very specific ways in these modules. Fixes#1876.
ilevkivskyi
approved these changes
Feb 14, 2020
ilevkivskyi
left a comment
Member
There was a problem hiding this comment.
LG, thanks! (The Windows tests still fail however.)
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Special cases a small set of modules so that they must be defined in
typeshed, as otherwise it's likely that mypy can crash, as it assumes
that various things are defined in very specific ways in these modules.
Fixes#1876.