Uh oh!
There was an error while loading. Please reload this page.
Fix generic inheritance for attrs init methods - #9383
Merged
Conversation
This was referenced Aug 30, 2020
natemcmaster
marked this pull request as ready for review
August 30, 2020 21:50
natemcmasterforce-pushed
the
attr-generic
branch
from
August 30, 2020 21:52
54dc7f5 to
5619bfaCompareContributorAuthor
It seems CI is currently broken on this project. The errors in windows builds appear to be a problem with the C++ toolchain, and on Travis, something is broken with setuptools. Not sure how to resolve those errors as they appear unrelated to my proposed changes. |
gvanrossum
commented
Aug 31, 2020
Member
Maybe this message on python-dev provides a clue? |
JelleZijlstra
commented
Sep 1, 2020
Member
Looks like pypa/setuptools#2350 (or similar), I'll try to submit a PR using the env var workaround. |
natemcmaster
commented
Sep 3, 2020
ContributorAuthor
CI is passing now on this PR. :) |
natemcmaster
commented
Sep 30, 2020
ContributorAuthor
Friendly bump for review :) |
natemcmaster
commented
Nov 13, 2020
ContributorAuthor
Hello there, checking in again. I merged from master and pushed to my branch to ensure this PR is still merge-conflict free and passing tests. Any chance I can get a review? Thanks! |
hauntsaninja
commented
Nov 28, 2020
Collaborator
Thank you again! :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes#5744
Updates the attrs plugin. Instead of directly copying attribute type along the MRO, this first resolves typevar in the context of the subtype.
Test Plan
Added 4 new test cases to cover various generic inheritance scenarios.