Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a major change and prevents the interpreter from sanity checking the return value of
PyMethodDefdefined functions. The signature ofMETH_VECTORCALLshould remain asPyObject *(*call) (PyObject *self, PyObject *const *args, Py_ssize_t nargs, PyObject *kwname)Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain. I don't think it's the job of the vectorcall callee to do that check, it should be done by the vectorcall caller.
For example, in your reference implementation, that check could be done by
_Py_VectorCall.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, it is the job of the callee to do this check.
_PyCFunction_FastCallKeywordsdoes this, as thePymethodDefdefined code is not entirely trusted. However, calls to the interpreter or builtin classes are trusted and don't need to be double checked.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why should the
PyMethodDef-defined code be less trusted than other code called by the vectorcall protocol? I don't see the difference.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Because
PyMethodDefremains the preferred way for builtin functions to be implemented if they are implemented in C. For tools like Cython that can ensure that the returned value is consistent, the additional check is not required.